mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-11-10 19:36:18 +01:00
5cddde1fb2
Prevent the situation where errno is set by function A, then function B
is called (which is typically _(), but could be anything else) and it
overwrites errno, then errno is checked by the caller.
errno is a horrific API, and we need to be careful to save its value as
soon as a function call (which might set it) returns. i.e. Follow the
pattern:
int errsv, ret;
ret = some_call_which_might_set_errno ();
errsv = errno;
if (ret < 0)
puts (strerror (errsv));
This patch implements that pattern throughout GLib. There might be a few
places in the test code which still use errno directly. They should be
ported as necessary. It doesn’t modify all the call sites like this:
if (some_call_which_might_set_errno () && errno == ESOMETHING)
since the refactoring involved is probably more harmful than beneficial
there. It does, however, refactor other call sites regardless of whether
they were originally buggy.
https://bugzilla.gnome.org/show_bug.cgi?id=785577
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| accumulator.c | ||
| defaultiface.c | ||
| deftype.c | ||
| dynamictype.c | ||
| gvalue-test.c | ||
| ifacecheck.c | ||
| ifaceinherit.c | ||
| ifaceinit.c | ||
| Makefile.am | ||
| meson.build | ||
| override.c | ||
| paramspec-test.c | ||
| performance-threaded.c | ||
| performance.c | ||
| references.c | ||
| run-performance.sh | ||
| signals.c | ||
| singleton.c | ||
| testcommon.h | ||
| testgobject.c | ||
| testmarshal.list | ||
| testmodule.c | ||
| testmodule.h | ||
| timeloop-closure.c | ||