mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2025-07-03 01:23:04 +02:00
d2e08b7dfe
g_object_weak_unref() would have done a fast-removal of the entry, which messes up the order of the weak notifications. During destruction of the object we emit the weak notifications. They are emitted in the order in which they were registered (FIFO). Except, when a g_object_weak_unref() messes up the order. Avoid that and preserve the order. Now, do a memmove(), which is O(n). But note that we already track weak references in a flat array that requires a O(n) linear search. Thus, g_object_weak_unref() was already O(n) and that didn't change. More importantly, users are well advised to limit themselves to a reasonably small number of weak notifications. And for small n, the linear search and the memmove() is an efficient solution.