mirror of
				https://gitlab.gnome.org/GNOME/glib.git
				synced 2025-11-04 10:08:56 +01:00 
			
		
		
		
	This is a partial revert and rework of commit
c79575362e, for the `gsettings` script
only (the other completion scripts are fine).
I blindly added quoting to everything shellcheck told me to, without
testing it properly.
As it turns out, the `$schemadir` argument to `gsettings` invocations
was deliberately not quoted, so that it would expand to zero arguments
if unset, and two arguments (`--schemadir /some/path`) if set earlier in
the command-being-completed.
Quoting it meant that it expanded to one argument (the empty string) if
unset, which caused the `gsettings` subcommands to fail, and hence any
further tab completion to fail.
Fix that as suggested on https://www.shellcheck.net/wiki/SC2086 by
turning `schemadir` into an array, which either has zero members if
unset, or two members if set.
Signed-off-by: Philip Withnall <pwithnall@gnome.org>
		
	
		
			
				
	
	
		
			118 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			118 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
#
 | 
						|
# Copyright 2010, 2012 Red Hat, Inc.
 | 
						|
# Copyright 2010 Allison Karlitskaya
 | 
						|
# Copyright 2011 Giovanni Campagna
 | 
						|
#
 | 
						|
# This library is free software; you can redistribute it and/or modify
 | 
						|
# it under the terms of the GNU Lesser General Public License as
 | 
						|
# published by the Free Software Foundation; either version 2.1 of the
 | 
						|
# licence, or (at your option) any later version.
 | 
						|
#
 | 
						|
# This is distributed in the hope that it will be useful, but WITHOUT
 | 
						|
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public
 | 
						|
# License for more details.
 | 
						|
#
 | 
						|
# You should have received a copy of the GNU Lesser General Public License
 | 
						|
# along with this library; if not, see <http://www.gnu.org/licenses/>.
 | 
						|
#
 | 
						|
# SPDX-License-Identifier: LGPL-2.1-or-later
 | 
						|
 | 
						|
# shellcheck shell=bash
 | 
						|
 | 
						|
# Check for bash
 | 
						|
[ -z "$BASH_VERSION" ] && return
 | 
						|
 | 
						|
####################################################################################################
 | 
						|
 | 
						|
__gsettings() {
 | 
						|
  local choices coffset schemadir=() gsettings_binary
 | 
						|
  gsettings_binary="$1"
 | 
						|
 | 
						|
  if [ "${COMP_CWORD}" -gt 2 ]; then
 | 
						|
      if [ "${COMP_WORDS[1]}" = --schemadir ]; then
 | 
						|
          # The eval complexity is needed to perform correct tilde expansion
 | 
						|
          # The array is needed to ensure we can keep it expanding to either zero
 | 
						|
          # or one option in the commands below, while keeping quoting correct.
 | 
						|
          # See https://www.shellcheck.net/wiki/SC2086
 | 
						|
          schemadir=("--schemadir" "$(eval "echo ${COMP_WORDS[2]}")")
 | 
						|
	  coffset=2
 | 
						|
      else
 | 
						|
	  coffset=0
 | 
						|
      fi
 | 
						|
  else
 | 
						|
      coffset=0
 | 
						|
  fi
 | 
						|
 | 
						|
  case "$((COMP_CWORD-coffset))" in
 | 
						|
    1)
 | 
						|
      choices=$'--schemadir\n--version\nhelp \nlist-schemas\nlist-relocatable-schemas\nlist-keys \nlist-children \nlist-recursively \nget \nrange \nset \nreset \nreset-recursively \nwritable \nmonitor \ndescribe '
 | 
						|
      ;;
 | 
						|
 | 
						|
    2)
 | 
						|
      case "${COMP_WORDS[$((coffset+1))]}" in
 | 
						|
	--schemadir)
 | 
						|
          # shellcheck disable=SC2207
 | 
						|
	  COMPREPLY=($(compgen -o dirnames -- "${COMP_WORDS[${COMP_CWORD}]}"))
 | 
						|
	  return 0
 | 
						|
	  ;;
 | 
						|
 | 
						|
        help)
 | 
						|
          choices=$'list-schemas\nlist-relocatable-schemas\nlist-keys\nlist-children\nlist-recursively\nget\nrange\nset\nreset\nreset-recursively\nwritable\nmonitor'
 | 
						|
          ;;
 | 
						|
        list-keys|list-children|list-recursively|reset-recursively)
 | 
						|
          choices="$("$gsettings_binary" "${schemadir[@]}" list-schemas 2> /dev/null)"$'\n'"$("$gsettings_binary" "${schemadir[@]}" list-relocatable-schemas 2> /dev/null | sed -e 's.$.:/.')"
 | 
						|
          ;;
 | 
						|
        list-schemas)
 | 
						|
          # shellcheck disable=SC2207
 | 
						|
          COMPREPLY=($(compgen -W "--print-paths" -- "${COMP_WORDS[${COMP_CWORD}]}"))
 | 
						|
          return 0
 | 
						|
          ;;
 | 
						|
 | 
						|
        get|range|set|reset|writable|monitor|describe)
 | 
						|
          choices="$("$gsettings_binary" "${schemadir[@]}" list-schemas 2> /dev/null | sed -e 's.$. .')"$'\n'"$("$gsettings_binary" "${schemadir[@]}" list-relocatable-schemas 2> /dev/null | sed -e 's.$.:/.')"
 | 
						|
          ;;
 | 
						|
      esac
 | 
						|
      ;;
 | 
						|
 | 
						|
    3)
 | 
						|
      case "${COMP_WORDS[$((coffset+1))]}" in
 | 
						|
        set)
 | 
						|
          choices="$("$gsettings_binary" "${schemadir[@]}" list-keys "${COMP_WORDS[$((coffset+2))]}" 2> /dev/null | sed -e 's.$. .')"
 | 
						|
          ;;
 | 
						|
 | 
						|
        get|range|reset|writable|monitor|describe)
 | 
						|
          choices="$("$gsettings_binary" "${schemadir[@]}" list-keys "${COMP_WORDS[$((coffset+2))]}" 2> /dev/null)"
 | 
						|
          ;;
 | 
						|
      esac
 | 
						|
      ;;
 | 
						|
 | 
						|
    4)
 | 
						|
      case "${COMP_WORDS[$((coffset+2))]}" in
 | 
						|
        set)
 | 
						|
          # shellcheck disable=SC2207
 | 
						|
          range=($("$gsettings_binary" "${schemadir[@]}" range "${COMP_WORDS[$((coffset+2))]}" "${COMP_WORDS[$((coffset+3))]}" 2> /dev/null))
 | 
						|
          case "${range[0]}" in
 | 
						|
            enum)
 | 
						|
              unset 'range[0]'
 | 
						|
             ;;
 | 
						|
            *)
 | 
						|
              unset range
 | 
						|
             ;;
 | 
						|
          esac
 | 
						|
          local IFS=$'\n'
 | 
						|
          choices="${range[*]}"
 | 
						|
          ;;
 | 
						|
      esac
 | 
						|
      ;;
 | 
						|
  esac
 | 
						|
 | 
						|
  local IFS=$'\n'
 | 
						|
  # shellcheck disable=SC2207
 | 
						|
  COMPREPLY=($(compgen -W "${choices}" -- "${COMP_WORDS[${COMP_CWORD}]}"))
 | 
						|
}
 | 
						|
 | 
						|
####################################################################################################
 | 
						|
 | 
						|
complete -o nospace -F __gsettings gsettings
 |