Philip Withnall 5cddde1fb2 Consistently save errno immediately after the operation setting it
Prevent the situation where errno is set by function A, then function B
is called (which is typically _(), but could be anything else) and it
overwrites errno, then errno is checked by the caller.

errno is a horrific API, and we need to be careful to save its value as
soon as a function call (which might set it) returns. i.e. Follow the
pattern:
  int errsv, ret;
  ret = some_call_which_might_set_errno ();
  errsv = errno;

  if (ret < 0)
    puts (strerror (errsv));

This patch implements that pattern throughout GLib. There might be a few
places in the test code which still use errno directly. They should be
ported as necessary. It doesn’t modify all the call sites like this:
  if (some_call_which_might_set_errno () && errno == ESOMETHING)
since the refactoring involved is probably more harmful than beneficial
there. It does, however, refactor other call sites regardless of whether
they were originally buggy.

https://bugzilla.gnome.org/show_bug.cgi?id=785577
2017-08-03 10:21:13 +01:00
..
2017-07-17 16:20:52 -04:00
2010-07-05 00:56:12 -04:00
2013-07-11 13:49:20 -04:00
2013-11-23 22:21:29 -05:00
2017-07-13 19:03:39 -04:00
2016-04-27 12:12:31 +08:00
2014-09-09 14:11:38 -04:00
2015-02-23 10:40:40 -05:00
2014-01-01 22:01:15 -05:00
2017-05-29 19:53:34 +02:00
2016-04-26 15:20:16 +02:00
2014-06-28 14:06:36 -04:00
2012-10-16 09:39:24 -04:00
2010-04-17 01:48:05 -04:00
2012-10-16 09:39:24 -04:00
2017-05-29 19:53:34 +02:00
2013-11-11 07:11:29 +01:00
2017-05-29 19:53:34 +02:00
2012-10-16 09:39:24 -04:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2014-01-13 16:12:31 -05:00
2017-05-29 19:53:34 +02:00
2012-10-16 09:39:24 -04:00
2013-06-02 20:02:06 -04:00
2012-10-16 09:39:24 -04:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2015-08-31 13:59:48 -04:00
2017-05-29 19:53:34 +02:00
2017-05-29 19:53:34 +02:00
2012-10-16 09:39:24 -04:00
2012-10-16 09:39:24 -04:00
2012-10-16 09:39:24 -04:00
2017-05-29 19:53:34 +02:00
2012-10-16 09:39:24 -04:00
2017-05-29 19:53:34 +02:00
2012-01-13 17:12:53 +01:00
2012-01-13 17:12:53 +01:00
2012-01-13 17:12:53 +01:00
2012-01-13 17:12:53 +01:00
2012-01-13 17:12:53 +01:00
2012-01-13 17:12:53 +01:00
2015-08-21 00:43:54 -04:00
2012-12-12 15:20:22 +01:00
2012-10-16 09:39:24 -04:00