fabdc2d4fa
In this tests we wanted to ensure that all the unused threads were stopped, however while we were calling g_thread_pool_stop_unused_threads some threads could still be in the process of being recycled even tough the pool's num_thread values are 0. In fact, stopping unused threads implies also resetting back the max unused threads to the previous value, and in this test it caused it to go from -1 -> 0 and back to -1, after killing the unused threads we knew about; thus any about-to-be-unused thread that is not killed during this call will be just left around as a waiting unused thread afterwards. However, if this function was getting called when a thread was in between of calling the user function and the moment it was being recycled (and so when the pool num_threads was updated), but this thread was not counted in unused_threads, we ended up in having a race because all the threads were consumed from our POV, but some were actually not yet unused, and so were kept waiting forever for some new job. To avoid this in the test, we can ensure that we stop the unused threads until we the number of them is really 0. Sadly we need to repeat this as we don't have a clear point in which we are sure about the fact that our threads are done, while it would be wrong to stop a thread that is technically not yet marked as unused. We could also do this in g_thread_pool_stop_unused_threads() itself, but it would make such function to wait for threads to complete, and this is probably not what was expected in the initial API. Fixes: #2685 |
||
|---|---|---|
| .gitlab-ci | ||
| .reuse | ||
| docs | ||
| fuzzing | ||
| gio | ||
| glib | ||
| gmodule | ||
| gobject | ||
| gthread | ||
| LICENSES | ||
| m4macros | ||
| po | ||
| subprojects | ||
| tests | ||
| tools | ||
| .clang-format | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .lcovrc | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| glib.doap | ||
| HACKING | ||
| INSTALL.md | ||
| meson_options.txt | ||
| meson.build | ||
| msvc_recommended_pragmas.h | ||
| NEWS | ||
| README.md | ||
| README.win32.md | ||
| SECURITY.md | ||
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file 'INSTALL.md'
Supported versions
Only the most recent unstable and stable release series are supported. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.
Default branch renamed to main
The default development branch of GLib has been renamed to main. To update
your local checkout, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main