mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-02-24 19:22:13 +01:00
Code

never pass an empty superseded_by as that violates the schema

Browse Source
This commit is contained in:
Ludwig Nussel 2010-12-21 14:17:12 +01:00
parent fb77b7b9f8
commit 046a2be24e
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osc/core.py
View File

@ -3317,19 +3317,23 @@ def get_request(apiurl, reqid):
return r return r
def change_review_state(apiurl, reqid, newstate, by_user='', by_group='', message='', supersed=''): def change_review_state(apiurl, reqid, newstate, by_user='', by_group='', message='', supersed=None):
query = {'cmd': 'changereviewstate', 'newstate': newstate, 'by_user': by_user, 'superseded_by': supersed} query = {'cmd': 'changereviewstate', 'newstate': newstate, 'by_user': by_user }
if by_group: if by_group:
query['by_group'] = by_group query['by_group'] = by_group
if supersed:
query['superseded_by'] = supersed
u = makeurl(apiurl, ['request', reqid], query=query) u = makeurl(apiurl, ['request', reqid], query=query)
f = http_POST(u, data=message) f = http_POST(u, data=message)
root = ET.parse(f).getroot() root = ET.parse(f).getroot()
return root.attrib['code'] return root.attrib['code']
def change_request_state(apiurl, reqid, newstate, message='', supersed=''): def change_request_state(apiurl, reqid, newstate, message='', supersed=None):
query={'cmd': 'changestate', 'newstate': newstate }
if supersed:
query['superseded_by'] = supersed
u = makeurl(apiurl, u = makeurl(apiurl,
['request', reqid], ['request', reqid], query=query)
query={'cmd': 'changestate', 'newstate': newstate, 'superseded_by': supersed})
f = http_POST(u, data=message) f = http_POST(u, data=message)
r = f.read() r = f.read()