1
0
mirror of https://github.com/openSUSE/osc.git synced 2024-12-28 10:46:15 +01:00

Merge branch 'fix_OscMirrorGroup_bug_with_network_not_reachable' of https://github.com/lethliel/osc

Catch URLError and remove superfluous counter in OscMirrorGroup.urlgrab.
This commit is contained in:
Marcus Huewe 2018-11-06 15:05:25 +01:00
commit 07b6b41154

View File

@ -11,10 +11,12 @@ try:
from urllib.request import HTTPError
from urllib.parse import urlparse
from urllib.parse import unquote
from urllib.error import URLError
except ImportError:
from urllib2 import HTTPError
from urlparse import urlparse
from urllib import unquote
from urllib2 import URLError
class OscFileGrabber(object):
@ -37,12 +39,12 @@ class OscMirrorGroup(object):
self._mirrors = mirrors
def urlgrab(self, url, filename=None, text=None):
tries = 0
for mirror in self._mirrors:
try:
self._grabber.urlgrab(mirror, filename, text)
return True
except HTTPError as e:
tries += 1
except (HTTPError, URLError) as e:
# try next mirror
pass
return False