mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-02-04 18:46:17 +01:00
Code

- Serviceinfo.execute: always cleanup (remove) tmpdir

Browse Source 
This fixes issue #24.
This commit is contained in:
Marcus Huewe 2013-04-26 20:43:53 +02:00
parent 9595aa9f09
commit 0c0ffe50fb
1 changed files with 24 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osc/core.py
View File

@ -383,6 +383,8 @@ class Serviceinfo:
if service['mode'] != "trylocal" and service['mode'] != "localonly" and callmode == "trylocal":
continue
call = service['command']
temp_dir = None
try:
temp_dir = tempfile.mkdtemp()
name = call.split(None, 1)[0]
if not os.path.exists("/usr/lib/obs/service/"+name):
@ -396,9 +398,6 @@ class Serviceinfo:
print("Aborting: service call failed: " + cmd)
# FIXME: addDownloadUrlService calls si.execute after
# updating _services.
for filename in os.listdir(temp_dir):
os.unlink(os.path.join(temp_dir, filename))
os.rmdir(temp_dir)
return r
if service['mode'] == "disabled" or service['mode'] == "trylocal" or service['mode'] == "localonly" or callmode == "local" or callmode == "trylocal":
@ -407,7 +406,9 @@ class Serviceinfo:
else:
for filename in os.listdir(temp_dir):
shutil.move( os.path.join(temp_dir, filename), os.path.join(dir, "_service:"+name+":"+filename) )
os.rmdir(temp_dir)
finally:
if temp_dir is not None:
shutil.rmtree(temp_dir)
return 0