From 0e7074f89c2146455fd2a350aa969ab2aa2f15be Mon Sep 17 00:00:00 2001 From: Marcus Huewe Date: Wed, 15 Dec 2010 14:31:18 +0100 Subject: [PATCH] - change_review_state: by_group param should be optional --- osc/core.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/osc/core.py b/osc/core.py index 50d26817..d517350e 100644 --- a/osc/core.py +++ b/osc/core.py @@ -3312,9 +3312,10 @@ def get_request(apiurl, reqid): def change_review_state(apiurl, reqid, newstate, by_user='', by_group='', message='', supersed=''): - u = makeurl(apiurl, - ['request', reqid], - query={'cmd': 'changereviewstate', 'newstate': newstate, 'by_user': by_user, 'by_group': by_group, 'superseded_by': supersed}) + query = {'cmd': 'changereviewstate', 'newstate': newstate, 'by_user': by_user, 'superseded_by': supersed} + if by_group: + query['by_group'] = by_group + u = makeurl(apiurl, ['request', reqid], query=query) f = http_POST(u, data=message) root = ET.parse(f).getroot() return root.attrib['code']