mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2024-09-21 17:56:19 +02:00
Code

Merge pull request #1281 from dmach/fix-POST-content-type

Browse Source 
connection: Set Content-Type of POST requests without data to 'application/x-www-form-urlencoded'
This commit is contained in:
Daniel Mach 2023-03-17 15:29:24 +01:00 committed by GitHub
commit 2b852846f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
behave/features/checkconstraints.feature Normal file
View File

@ -0,0 +1,18 @@
Feature: `osc checkconstraints` command
# common steps for all scenarios
Background:
Given I set working directory to "{context.osc.temp}"
Scenario: Run `osc checkconstraints <project>/<package> <repository>/<arch>`
When I execute osc with args "checkconstraints test:factory/test-pkgA standard/x86_64"
Then the exit code is 0
Scenario: Run `osc checkconstraints` from a package working copy
Given I execute osc with args "co test:factory/test-pkgA"
And I set working directory to "{context.osc.temp}/test:factory/test-pkgA"
When I execute osc with args "checkconstraints"
Then the exit code is 0

5
osc/connection.py
View File

@ -288,9 +288,10 @@ def http_request(method: str, url: str, headers=None, data=None, file=None):
# https://github.com/openSUSE/open-build-service/pull/13019
headers.add("Accept", "application/xml")
if data or file:
# osc/obs data is usually XML
if method == "PUT" or (method == "POST" and (data or file)):
headers.add("Content-Type", "application/xml; charset=utf-8")
elif method == "POST":
headers.add("Content-Type", "application/x-www-form-urlencoded")
if purl.scheme == "http" and HTTP_PROXY_MANAGER:
# HTTP proxy requires full URL with 'same host' checking off