mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-10-04 16:49:20 +02:00
Code Activity

- make it possible to list by given review states

Browse Source 
it used the state always for request and review state before, which makes no sense.

makes the code a bit nicer as well hopefully as well
This commit is contained in:
Adrian Schröter
2014-08-25 17:02:56 +02:00
parent 3adb160e0f
commit 3b6f7f1269
2 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
osc/commandline.py
View File

@@ -2015,7 +2015,7 @@ Please submit there instead, or use --nodevelproject to force direct submission.
if opts.state == '':
opts.state = 'all'
if opts.state == '':
if opts.state == '' and subcmd != 'review':
opts.state = 'declined,new,review'
if args[0] == 'help':
@@ -2115,13 +2115,10 @@ Please submit there instead, or use --nodevelproject to force direct submission.
results = get_request_list(apiurl, project, package, '', ['new'])
else:
state_list = opts.state.split(',')
if state_list == ['']:
state_list = ()
if opts.all:
state_list = ['all']
if subcmd == 'review':
# is there a special reason why we do not respect the passed states?
state_list = ['new']
elif opts.state == 'all':
state_list = ['all']
else:
for s in state_list:
if not s in states and not s == 'all':