From 40f4a61cbc68fedae750cd13892bc1b72df8a172 Mon Sep 17 00:00:00 2001 From: Marcus Huewe Date: Tue, 7 Apr 2015 15:27:40 +0200 Subject: [PATCH] - change_request_state: manual xml parsing is error-prone --- osc/core.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/osc/core.py b/osc/core.py index 2fc5beb1..21d89d77 100644 --- a/osc/core.py +++ b/osc/core.py @@ -4044,12 +4044,8 @@ def change_request_state(apiurl, reqid, newstate, message='', supersed=None, for ['request', reqid], query=query) f = http_POST(u, data=message) - r = f.read() - if r.startswith('')[0] - - return r + root = ET.parse(f).getroot() + return root.get('code', 'unknown') def change_request_state_template(req, newstate): if not len(req.actions):