From 4b95a716209fecd0cf9f1b510f92fd5f513dcbe3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Fri, 12 Feb 2010 18:37:12 +0100 Subject: [PATCH] avoid useless conversion to set that randomizes arguments order I admit my Python skills are pretty weak, but this set conversion appears to be useless and it can change order of arguments from e.g. --jobs 2 --icecream 20 to --icecream 20 --jobs 2 As the --jobs 2 actually comes from OSC itself on multicore systems and --icecream 20 was passed from the command line, this obviously renders the --icecream argument rather useless. --- osc/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osc/build.py b/osc/build.py index 5da36b32..c112d914 100644 --- a/osc/build.py +++ b/osc/build.py @@ -521,7 +521,7 @@ def main(opts, argv): if bi.release: buildargs.append('--release %s' % bi.release) - buildargs = ' '.join(set(buildargs)) + buildargs = ' '.join(buildargs) # real arch of this machine # vs.