From 54ea13493b7ff7e05ab86954300c5a72105665aa Mon Sep 17 00:00:00 2001 From: Daniel Mach Date: Tue, 9 Apr 2024 17:51:50 +0200 Subject: [PATCH] Fix do_createrequest() function to return None instead of request id This was a bad API, command handlers should return None or an exit code. Anything that returns an actual value belongs to the library instead. --- osc/commandline.py | 1 - 1 file changed, 1 deletion(-) diff --git a/osc/commandline.py b/osc/commandline.py index 845b7df1..340ba6da 100644 --- a/osc/commandline.py +++ b/osc/commandline.py @@ -2828,7 +2828,6 @@ Please submit there instead, or use --nodevelproject to force direct submission. for srid in supersede: change_request_state(apiurl, srid, 'superseded', f'superseded by {rid}', rid) - return rid @cmdln.option('-m', '--message', metavar='TEXT', help='specify message TEXT')