From 73d880e138591140d7ee7fa6138fc5d33ff24d93 Mon Sep 17 00:00:00 2001 From: Marcus Huewe Date: Thu, 6 Feb 2020 10:09:52 +0100 Subject: [PATCH] Fix bogus None check in core.vc_export_env In case of an error, core.get_user_data returns an empty list. None is never returned. Hence, only pop data from the returned list, if it is non-empty. --- osc/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osc/core.py b/osc/core.py index ba596db2..0febec30 100644 --- a/osc/core.py +++ b/osc/core.py @@ -7901,7 +7901,7 @@ def vc_export_env(apiurl, quiet=False): if missing_tags: user = conf.get_apiurl_usr(apiurl) data = get_user_data(apiurl, user, *missing_tags) - if data is not None: + if data: for tag in missing_tags: val = data.pop(0) if val != '-':