From 7fcb1bbe3e2c605febea006bd3d0e451e255d3ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20Schr=C3=B6ter?= Date: Fri, 24 Jan 2014 10:29:00 +0100 Subject: [PATCH] - fix set bugowner command --- osc/commandline.py | 4 ++-- osc/core.py | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/osc/commandline.py b/osc/commandline.py index 0601862a..83496fa7 100644 --- a/osc/commandline.py +++ b/osc/commandline.py @@ -7120,7 +7120,7 @@ Please submit there instead, or use --nodevelproject to force direct submission. if opts.set_bugowner: for role in roles: try: - setBugowner(apiurl, result.get('project'), result.get('package'), bugowner) + setBugowner(apiurl, result.get('project'), result.get('package'), opts.set_bugowner) except HTTPError as e: if e.code == 403: print("No write permission in", result.get('project'), end=' ') @@ -7144,7 +7144,7 @@ Please submit there instead, or use --nodevelproject to force direct submission. if opts.set_bugowner: for role in roles: try: - setBugowner(apiurl, prj, pac, opts.delete, role) + setBugowner(apiurl, prj, pac, opts.set_bugowner) except HTTPError as e: if e.code == 403: print("No write permission in" + result.get('project'), end=' ') diff --git a/osc/core.py b/osc/core.py index 0dd51990..2d9edd29 100644 --- a/osc/core.py +++ b/osc/core.py @@ -6088,12 +6088,12 @@ def setBugowner(apiurl, prj, pac, user=None, group=None): create_new=False) if data: root = ET.fromstring(''.join(data)) - for group in root.getiterator('group'): - if group.get('role') == "bugowner": - root.remove(group) - for person in root.getiterator('person'): - if person.get('role') == "bugowner": - root.remove(person) + for group_element in root.getiterator('group'): + if group_element.get('role') == "bugowner": + root.remove(group_element) + for person_element in root.getiterator('person'): + if person_element.get('role') == "bugowner": + root.remove(person_element) if user: root.insert(2, ET.Element('person', role='bugowner', userid=user)) elif group: