From a031dbd0830bf7e95ee849d29856e5a80898ab92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrian=20Schr=C3=B6ter?= Date: Thu, 13 Aug 2015 07:57:08 +0200 Subject: [PATCH] show review comments in an own line. Before they started in the same line, but reached on typical screens anyway the second line if they had more than a few chars. --- osc/core.py | 4 +++- tests/test_request.py | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/osc/core.py b/osc/core.py index 5f7bd184..0b48d63c 100644 --- a/osc/core.py +++ b/osc/core.py @@ -2885,7 +2885,9 @@ class Request: d['by'] = "Project: " + review.by_project d['when'] = review.when or '' d['who'] = review.who or '' - d['comment'] = review.comment or '' + d['comment'] = '' + if review.comment: + d['comment'] = '\n ' + review.comment reviews.append(tmpl % d) if reviews: lines.append('\nReview: %s' % indent.join(reviews)) diff --git a/tests/test_request.py b/tests/test_request.py index 4fe2fb7a..d7cdd5a8 100644 --- a/tests/test_request.py +++ b/tests/test_request.py @@ -483,8 +483,10 @@ test. State: review 2010-12-27T01:36:29 abc Comment: currently in review -Review: accepted Group: group1 2010-12-29T00:11:22 abc accepted - new Group: group1 2010-12-28T00:11:22 abc review start +Review: accepted Group: group1 2010-12-29T00:11:22 abc + accepted + new Group: group1 2010-12-28T00:11:22 abc + review start History: 2010-12-12T00:00:00 creator revoked 2010-12-11T00:00:00 creator new"""