mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-11-25 06:06:30 +01:00
Code Activity

feat: add new function PullRequest.get_host_owner_repo_number

Browse Source 
The existing `get_owner_repo_number` throws away the parsed host, which is
occasionally useful. Therefore we add a new method `get_host_owner_repo_number`
that also returns the full host (scheme + hostname + port) and keep the old
method for compatibility.

Also add tests.
This commit is contained in:
Dan Čermák
2025-10-20 17:15:34 +02:00
parent 5d244c9381
commit aa3cb2c71f
2 changed files with 72 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
osc/gitea_api/pr.py
View File

@@ -90,20 +90,32 @@ class PullRequest(GiteaModel):
raise ValueError(f"Invalid pull request id: {pr_id}")
return match.group(1), match.group(2), int(match.group(3))
@staticmethod
def get_host_owner_repo_number(url: str) -> Tuple[str, str, str, int]:
"""
Parse pull request URL such as http(s)://example.com:<port>/<owner>/<repo>/pulls/<number>
and return (host, owner, repo, number) tuple.
The host is returned as the full base URL (scheme://netloc), e.g., "https://example.com:3000".
"""
import urllib.parse
parsed_url = urllib.parse.urlparse(url)
host = f"{parsed_url.scheme}://{parsed_url.netloc}"
path = parsed_url.path
owner, repo, pulls, number = path.strip("/").split("/")
if pulls not in ("pulls", "issues"):
raise ValueError(f"URL doesn't point to a pull request or an issue: {url}")
return host, owner, repo, int(number)
@staticmethod
def get_owner_repo_number(url: str) -> Tuple[str, str, int]:
"""
Parse pull request URL such as http(s)://example.com:<port>/<owner>/<repo>/pulls/<number>
and return (owner, repo, number) tuple.
"""
import urllib.parse
parsed_url = urllib.parse.urlparse(url)
path = parsed_url.path
owner, repo, pulls, number = path.strip("/").split("/")
if pulls not in ("pulls", "issues"):
raise ValueError(f"URL doesn't point to a pull request or an issue: {url}")
return owner, repo, int(number)
_, owner, repo, number = PullRequest.get_host_owner_repo_number(url)
return owner, repo, number
def parse_pr_references(self) -> List[Tuple[str, str, int]]:
refs = re.findall(r"^PR: *(.*)$", self.body, re.M)