1
0
mirror of https://github.com/openSUSE/osc.git synced 2024-12-27 02:16:12 +01:00

check the right options for request and review command

This commit is contained in:
Adrian Schröter 2010-08-10 16:36:29 +02:00
parent eada1234a9
commit e0172293df

View File

@ -1525,19 +1525,23 @@ Please submit there instead, or use --nodevelproject to force direct submission.
osc request list [-M] [-U USER] [-s state] [-D DAYS] [-t type] [-B] [PRJ [PKG]] osc request list [-M] [-U USER] [-s state] [-D DAYS] [-t type] [-B] [PRJ [PKG]]
osc request log ID osc request log ID
osc request [show] [-d] [-b] ID osc request [show] [-d] [-b] ID
osc request accept [-m TEXT] ID osc request accept [-m TEXT] ID
osc request clone [-m TEXT] ID
osc request reopen [-m TEXT] ID
osc request approvenew [-m TEXT] PROJECT
osc request decline [-m TEXT] ID osc request decline [-m TEXT] ID
osc request revoke [-m TEXT] ID osc request revoke [-m TEXT] ID
osc request wipe ID osc request wipe ID
osc request reopen [-m TEXT] ID
osc request approvenew [-m TEXT] PROJECT
osc request checkout/co ID osc request checkout/co ID
osc request clone [-m TEXT] ID
osc review list [-U USER] [-G GROUP] [-s state] osc review list [-U USER] [-G GROUP] [-s state]
osc review add [-U USER] [-G GROUP] ID osc review add [-U USER] [-G GROUP] ID
osc review accept [-m TEXT] ID osc review accept [-m TEXT] ID
osc review decline [-m TEXT] ID osc review decline [-m TEXT] ID
osc review new [-m TEXT] ID # for setting a temporary comment without changing the state osc review new [-m TEXT] ID # for setting a temporary comment without changing the state
${cmd_option_list} ${cmd_option_list}
""" """
@ -1562,17 +1566,21 @@ Please submit there instead, or use --nodevelproject to force direct submission.
if opts.state == '': if opts.state == '':
opts.state = 'new' opts.state = 'new'
cmds = ['add', 'list', 'log', 'show', 'decline', 'reopen', 'clone', 'accept', 'approvenew', 'wipe', 'revoke', 'checkout', 'co', 'help'] if cmd == 'help':
if not args or args[0] not in cmds: return self.do_help(['help', 'request'])
cmds = [ 'list', 'log', 'show', 'decline', 'reopen', 'clone', 'accept', 'approvenew', 'wipe', 'revoke', 'checkout', 'co' ]
if subcmd != 'review' and not args or args[0] not in cmds:
raise oscerr.WrongArgs('Unknown request action %s. Choose one of %s.' \ raise oscerr.WrongArgs('Unknown request action %s. Choose one of %s.' \
% (args[0],', '.join(cmds))) % (args[0],', '.join(cmds)))
cmds = [ 'list', 'add', 'decline', 'accept', 'new' ]
if subcmd == 'review' and not args or args[0] not in cmds:
raise oscerr.WrongArgs('Unknown review action %s. Choose one of %s.' \
% (args[0],', '.join(cmds)))
cmd = args[0] cmd = args[0]
del args[0] del args[0]
if cmd == 'help':
return self.do_help(['help', 'request'])
if cmd in ['list']: if cmd in ['list']:
min_args, max_args = 0, 2 min_args, max_args = 0, 2
else: else: