mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-02-02 17:56:15 +01:00
Code

- show api error on failure of request/review accept

Browse Source
This commit is contained in:
Adrian Schröter 2014-01-30 11:52:24 +01:00
parent 0557fecd02
commit e1007e1bd8
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osc/commandline.py
View File

@ -2259,6 +2259,8 @@ Please submit there instead, or use --nodevelproject to force direct submission.
review.by_project, review.by_package, opts.message or '', supersed=supersedid) review.by_project, review.by_package, opts.message or '', supersed=supersedid)
print(r) print(r)
except HTTPError as e: except HTTPError as e:
body = e.read()
if e.code in [403]:
if review.by_user: if review.by_user:
print('No permission on review by user %s' % review.by_user) print('No permission on review by user %s' % review.by_user)
if review.by_group: if review.by_group:
@ -2267,6 +2269,8 @@ Please submit there instead, or use --nodevelproject to force direct submission.
print('No permission on review by package %s / %s' % (review.by_project, review.by_package)) print('No permission on review by package %s / %s' % (review.by_project, review.by_package))
elif review.by_project: elif review.by_project:
print('No permission on review by project %s' % review.by_project) print('No permission on review by project %s' % review.by_project)
else:
print(e, file=sys.stderr)
else: else:
print('Request is closed, please reopen the request first before changing any reviews.') print('Request is closed, please reopen the request first before changing any reviews.')
# Change state of entire request # Change state of entire request
@ -2292,8 +2296,8 @@ Please submit there instead, or use --nodevelproject to force direct submission.
reqid, state_map[cmd], opts.message or '', supersed=supersedid, force=opts.force) reqid, state_map[cmd], opts.message or '', supersed=supersedid, force=opts.force)
print('Result of change request state: %s' % r) print('Result of change request state: %s' % r)
except HTTPError as e: except HTTPError as e:
if opts.or_revoke:
print(e, file=sys.stderr) print(e, file=sys.stderr)
if opts.or_revoke:
body = e.read() body = e.read()
if e.code in [ 400, 403, 404, 500 ]: if e.code in [ 400, 403, 404, 500 ]:
print('Revoking it ...') print('Revoking it ...')