mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-11-02 12:32:16 +01:00
Code Activity

Properly handle deleted users and teams in the git-obs timeline

Browse Source
This commit is contained in:
Daniel Mach
2025-09-12 11:55:18 +02:00
parent 2b10d204da
commit f022e08c28
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
osc/gitea_api/issue_timeline_entry.py
View File

@@ -158,8 +158,18 @@ class IssueTimelineEntry(GiteaModel):
return f"{msg} the review", self.body
def _format_review_request(self):
reviewer = self._data["assignee"]["login"] if self._data["assignee"] else self._data["assignee_team"]["name"]
return f"requested review from {reviewer}", self.body
action = "removed" if self._data["removed_assignee"] else "requested"
if self._data["assignee"]:
reviewer = self._data["assignee"]["login"]
if self._data["assignee"]["id"] == -1:
reviewer += " (DELETED)"
elif self._data["assignee_team"]:
reviewer = self._data["assignee_team"]["name"]
else:
reviewer = "Ghost Team (DELETED)"
return f"{action} review from {reviewer}", self.body
# unused; we are not interested in these types of entries