Added new function run_pager() to get 'osc log/diff' work like
'git log/diff' which send the output to PAGER (which is by default:
less or what's defined in the environment).
Signed-off-by: Danny Kukawka <danny.kukawka@web.de>
From 1f9b748c733624e86777173a3fff399d622073b8 Mon Sep 17 00:00:00 2001
From: Danny Kukawka <danny.kukawka@web.de>
Date: Fri, 30 Apr 2010 17:24:04 +0200
Subject: [PATCH] fix some more close() statements
Fixed warning from pychecker by fixing some close() statements.
Signed-off-by: Danny Kukawka <danny.kukawka@web.de>
From 208250448c5d438f3906879993013ee126152ce2 Mon Sep 17 00:00:00 2001
From: Danny Kukawka <danny.kukawka@web.de>
Date: Fri, 30 Apr 2010 17:45:41 +0200
Subject: [PATCH] fixed warning from pychecker
Fixed warning from pychecker: 'Comparisons with True are not necessary
and may not work as expected'
Signed-off-by: Danny Kukawka <danny.kukawka@web.de>
We might have this also in other places, it is not enough anymore to check for the
existens of a package _meta file, we need also to check the "project" attribute, if it
really comes from this project.
The osc.core.get_results parses the xml and also construct the status
field in little bit complicate way. For future csv support it is
necessary split the xml parsing and formatting to two functions:
* get_package_results - returns a dict containing all important
elements
* get_results - behave as old implementation, just do a formating only
bye bye urlgrabber.grabber.URLGrabber: now we're using our own "grabber" object
(OscFileGrabber()) because this way we can reuse the urllib2 handlers (the latest
python-urlgrabber version uses python-curl instead of urllib2...).
- removed build_xpath_predicate()
- rewrote search()
- added xpath_join() to join two xpath expressions
- TODO: backward compatibility: currently do_search() requires a recent
api version from git master in order to do some role filter stuff
This happens, if a file was previously deleted, and the user changes his
mind before a commit. Such an add is no longer an add, but a cancel for the
planned delete. This resulted in unexpected loss of the file, on the server, as
the message 'is already under version control' is quite misleading in this case.
