Doing this to not brake scripts where this option is used.
This Patch is a follow-up of
568612ce "- drop hardcoded source validator executions"
which has not been released yet.
On Friday 09 September 2011, Marcus Hüwe wrote:
> > Is this the supposed behavior?
>
> No - I just fixed it in git master.
Thx!
BTW
even I've investigated it for svn (because osc may supposed to be similar).
But the misbehavior is the same there. Do you think that's a bug in svn too?
At least svn reverts completely when doing
svn revert -R .
Probably would be also nice to say something about it in osc revert --help,
e.g. like this
From 3fa9bb1ac29c623f8ee24f435e7eebd073273e1a Mon Sep 17 00:00:00 2001
From: Ruediger Meier <ruediger.meier@ga-group.nl>
Date: Fri, 9 Sep 2011 19:08:50 +0200
Subject: [PATCH] - do_revert: add help msg about reverting wc entirely
This duplicates the work of the source validator and is just annoying.
Suggested-by: Michal Vyskocil <mvyskocil@suse.cz>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Exchange individual return statements with a finally statement in the
big try/except statement in babysitter.py. If you return a different
value in the 'except' clause, it takes precedency over the 'finally'
clause (finally is executed before returning, naturally).
This fixes:
~> osc checkout
Traceback (most recent call last):
File "/usr/bin/osc", line 21, in <module>
r = babysitter.run(osccli)
File "/usr/lib/python2.7/site-packages/osc/babysitter.py", line 52, in run
return prg.main()
File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 310, in main
return self.cmd(args)
File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 333, in cmd
retval = self.onecmd(argv)
File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 449, in onecmd
return self._dispatch_cmd(handler, argv)
File "/usr/lib/python2.7/site-packages/osc/cmdln.py", line 1179, in _dispatch_cmd
return handler(argv[0], opts, *args)
File "/usr/lib/python2.7/site-packages/osc/commandline.py", line 3386, in do_checkout
m = re.match(r"obs://([^/]+)/(\S+)/([^/]+)/([A-Fa-f\d]+)\-(\S+)", args[0])
IndexError: tuple index out of range
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
