mirror of
https://github.com/openSUSE/osc.git
synced 2025-02-24 11:12:14 +01:00
90ccc84f95
Only ask for a password if it is really needed for authentication. The new lazy password approach is much smarter than the old callable hack. That's why we deprecate returning a callable from AbstractCredentialsManager.get_password. The current compatibility code for a callable will be removed in the near future. Minor nitpick: actually it would have been "cleaner" to introduce a new subclass like an AbstractLazyPasswordCredentialsManager that encapsulates the lazy password behavior. Currently, if, for instance, a credentials manager is always non-lazy it would just override get_password but still inherits the abstract (and unused) _get_password method.