mirror of
https://github.com/openSUSE/osc.git
synced 2025-02-06 03:10:57 +01:00
b8482bfab3
The old code passes try_again=False to the recursive postoptparse call when calling it from one of the exception handlers. This is wrong because it can result in an incomplete conf.config dict (for instance, if two apiurl sections have no user and no password and no credentials_mgr_class option - see #761 ("Traceback config with two backends and no username")). Hence, Osc.postoptparse should only return if the conf.get_config call succeeds. For this, unconditionally call Osc.postoptparse from within the exception handlers. Note: this could potentially (although quite unlikely) result in an endless recursion but in each recursive call "user" interaction is required (that is, the user could simply press CTRL+c) - so this should not be a problem. Implementation note: this change breaks the API. Rationale: the semantics of Osc.postoptparse changed. Hence, "pretending" to honor the try_again parameter could result in unexpected behavior (from the API consumer's POV). Hence, a traceback might be more sensible. Fixes: #761 ("Traceback config with two backends and no username")