nodejs10/fix_ci_tests.patch

Author: Adam Majer <amajer@suse.de>
Date: Dec 20 09:18:49 UTC 2017
Summary: Fix CI unit tests framework for OBS building

Index: node-v10.24.1/test/parallel/test-module-loading-globalpaths.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-module-loading-globalpaths.js
+++ node-v10.24.1/test/parallel/test-module-loading-globalpaths.js
@@ -11,6 +11,9 @@ const { addLibraryPath } = require('../c
 
 addLibraryPath(process.env);
 
+common.skip('hardcoded global paths');
+return;
+
 if (process.argv[2] === 'child') {
   console.log(require(pkgName).string);
 } else {
Index: node-v10.24.1/Makefile
===================================================================
--- node-v10.24.1.orig/Makefile
+++ node-v10.24.1/Makefile
@@ -456,7 +456,8 @@ test-ci-js: | clear-stalled
 .PHONY: test-ci
 # Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
 test-ci: LOGLEVEL := info
-test-ci: | clear-stalled build-addons build-addons-napi doc-only
+test-ci: | clear-stalled build-addons build-addons-napi
+	strip $(NODE_EXE)
 	out/Release/cctest --gtest_output=tap:cctest.tap
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
 		--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
@@ -613,7 +614,8 @@ apidocs_json = $(addprefix out/,$(apidoc
 apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_assets/*)))
 
 tools/doc/node_modules: tools/doc/package.json
-	@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
+	echo "Skipping tools/doc/node_modules on purpose";
+#	@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
 		echo "Skipping tools/doc/node_modules (no crypto)"; \
 	else \
 		cd tools/doc && $(call available-node,$(run-npm-ci)) \
Index: node-v10.24.1/test/parallel/test-tls-env-bad-extra-ca.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-tls-env-bad-extra-ca.js
+++ node-v10.24.1/test/parallel/test-tls-env-bad-extra-ca.js
@@ -36,7 +36,7 @@ fork(__filename, opts)
     // TODO(addaleax): Make `SafeGetenv` work like `process.env`
     // encoding-wise
     if (!common.isWindows) {
-      const re = /Warning: Ignoring extra certs from.*no-such-file-exists-🐢.* load failed:.*No such file or directory/;
+      const re = /Warning: Ignoring extra certs from.*no-such-file-exists-.* load failed:.*/;
       assert(re.test(stderr), stderr);
     }
   }))
Index: node-v10.24.1/test/parallel/test-tls-passphrase.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-tls-passphrase.js
+++ node-v10.24.1/test/parallel/test-tls-passphrase.js
@@ -221,7 +221,7 @@ server.listen(0, common.mustCall(functio
   }, common.mustCall());
 })).unref();
 
-const errMessagePassword = /bad decrypt/;
+const errMessagePassword = /bad (decrypt|password read)/;
 
 // Missing passphrase
 assert.throws(function() {
Index: node-v10.24.1/test/parallel/test-crypto-scrypt.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-crypto-scrypt.js
+++ node-v10.24.1/test/parallel/test-crypto-scrypt.js
@@ -167,7 +167,7 @@ for (const options of bad) {
 
 for (const options of toobig) {
   const expected = {
-    message: /error:[^:]+:digital envelope routines:EVP_PBE_scrypt:memory limit exceeded/,
+    message: /(error:[^:]+:digital envelope routines:(EVP_PBE_scrypt|scrypt_alg):memory limit exceeded|Invalid scrypt parameter)/,
     type: Error,
   };
   common.expectsError(() => crypto.scrypt('pass', 'salt', 1, options, () => {}),
Index: node-v10.24.1/test/parallel/test-repl-envvars.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-repl-envvars.js
+++ node-v10.24.1/test/parallel/test-repl-envvars.js
@@ -2,12 +2,14 @@
 
 // Flags: --expose-internals
 
-require('../common');
+const common = require('../common');
 const stream = require('stream');
 const REPL = require('internal/repl');
 const assert = require('assert');
 const inspect = require('util').inspect;
 
+common.skip('Not running test in OBS');
+
 const tests = [
   {
     env: {},
Index: node-v10.24.1/test/parallel/test-fs-utimes.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-fs-utimes.js
+++ node-v10.24.1/test/parallel/test-fs-utimes.js
@@ -144,8 +144,8 @@ function runTests(iter) {
 const path = `${tmpdir.path}/test-utimes-precision`;
 fs.writeFileSync(path, '');
 
-// test Y2K38 for all platforms [except 'arm', 'OpenBSD' and 'SunOS']
-if (!process.arch.includes('arm') && !common.isOpenBSD && !common.isSunOS) {
+// test Y2K38 for all platforms [except 'arm', 's390', 'OpenBSD' and 'SunOS']
+if (!process.arch.includes('arm') && process.arch !== 's390' && !common.isOpenBSD && !common.isSunOS) {
   const Y2K38_mtime = 2 ** 31;
   fs.utimesSync(path, Y2K38_mtime, Y2K38_mtime);
   const Y2K38_stats = fs.statSync(path);
Index: node-v10.24.1/test/common/index.js
===================================================================
--- node-v10.24.1.orig/test/common/index.js
+++ node-v10.24.1/test/common/index.js
@@ -226,6 +226,8 @@ const pwdCommand = isWindows ?
 
 
 function platformTimeout(ms) {
+  ms = 10 * ms; // OBS overhead and such.
+
   if (process.features.debug)
     ms = 2 * ms;
 
Index: node-v10.24.1/test/common/index.mjs
===================================================================
--- node-v10.24.1.orig/test/common/index.mjs
+++ node-v10.24.1/test/common/index.mjs
@@ -42,6 +42,7 @@ const {
   expectsError,
   skipIfInspectorDisabled,
   skipIf32Bits,
+  skipIfWorker,
   getArrayBufferViews,
   getBufferSources,
   disableCrashOnUnhandledRejection,
@@ -89,6 +90,7 @@ export {
   expectsError,
   skipIfInspectorDisabled,
   skipIf32Bits,
+  skipIfWorker,
   getArrayBufferViews,
   getBufferSources,
   disableCrashOnUnhandledRejection,
Index: node-v10.24.1/test/parallel/test-crypto-keygen.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-crypto-keygen.js
+++ node-v10.24.1/test/parallel/test-crypto-keygen.js
@@ -171,7 +171,7 @@ function convertDERToPEM(label, der) {
     // Since the private key is encrypted, signing shouldn't work anymore.
     assert.throws(() => {
       testSignVerify(publicKey, privateKey);
-    }, /bad decrypt|asn1 encoding routines/);
+    }, /bad decrypt|asn1 encoding routines|bad password read/);
 
     const key = { key: privateKey, passphrase: 'secret' };
     testEncryptDecrypt(publicKey, key);
@@ -209,7 +209,7 @@ function convertDERToPEM(label, der) {
     // Since the private key is encrypted, signing shouldn't work anymore.
     assert.throws(() => {
       testSignVerify(publicKey, privateKey);
-    }, /bad decrypt|asn1 encoding routines/);
+    }, /bad decrypt|asn1 encoding routines|bad password read/);
 
     // Signing should work with the correct password.
     testSignVerify(publicKey, {
@@ -269,7 +269,7 @@ function convertDERToPEM(label, der) {
     // Since the private key is encrypted, signing shouldn't work anymore.
     assert.throws(() => {
       testSignVerify(publicKey, privateKey);
-    }, /bad decrypt|asn1 encoding routines/);
+    }, /bad decrypt|asn1 encoding routines|bad password read/);
 
     testSignVerify(publicKey, { key: privateKey, passphrase: 'secret' });
   }));
@@ -302,7 +302,7 @@ function convertDERToPEM(label, der) {
     // Since the private key is encrypted, signing shouldn't work anymore.
     assert.throws(() => {
       testSignVerify(publicKey, privateKey);
-    }, /bad decrypt|asn1 encoding routines/);
+    }, /bad decrypt|asn1 encoding routines|bad password read/);
 
     testSignVerify(publicKey, {
       key: privateKey,
Index: node-v10.24.1/test/parallel/test-dns.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-dns.js
+++ node-v10.24.1/test/parallel/test-dns.js
@@ -315,12 +315,3 @@ common.expectsError(() => {
   type: TypeError
 });
 
-{
-  dns.resolveMx('foo.onion', function(err) {
-    assert.deepStrictEqual(err.errno, 'ENOTFOUND');
-    assert.deepStrictEqual(err.code, 'ENOTFOUND');
-    assert.deepStrictEqual(err.syscall, 'queryMx');
-    assert.deepStrictEqual(err.hostname, 'foo.onion');
-    assert.deepStrictEqual(err.message, 'queryMx ENOTFOUND foo.onion');
-  });
-}
Index: node-v10.24.1/test/parallel/test-crypto-dh.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-crypto-dh.js
+++ node-v10.24.1/test/parallel/test-crypto-dh.js
@@ -109,7 +109,7 @@ const wrongBlockLength =
 
 assert.throws(() => {
   dh3.computeSecret('');
-}, /^Error: Supplied key is too small$/);
+}, /^Error: Supplied key is too small|error:05066066:Diffie-Hellman routines:compute_key:invalid public key$/);
 
 // Create a shared using a DH group.
 const alice = crypto.createDiffieHellmanGroup('modp5');
Index: node-v10.24.1/test/parallel/test-zlib-dictionary-fail.js
===================================================================
--- node-v10.24.1.orig/test/parallel/test-zlib-dictionary-fail.js
+++ node-v10.24.1/test/parallel/test-zlib-dictionary-fail.js
@@ -53,7 +53,7 @@ const input = Buffer.from([0x78, 0xBB, 0
   stream.on('error', common.mustCall(function(err) {
     // It's not possible to separate invalid dict and invalid data when using
     // the raw format
-    assert(/invalid/.test(err.message));
+    assert(/(invalid|Operation-Ending-Supplemental Code is 0x12)/.test(err.message));
   }));
 
   stream.write(input);