diff --git a/Log-Log4perl-1.18.tar.bz2 b/Log-Log4perl-1.18.tar.bz2
new file mode 100644
index 0000000..1cead61
--- /dev/null
+++ b/Log-Log4perl-1.18.tar.bz2
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:36d2e66d1972990d0ffc94523fa087f51365c3cfcb48c8e6a7aea311c23923c3
+size 169335
diff --git a/Log-Log4perl-1.18.tar.gz b/Log-Log4perl-1.18.tar.gz
deleted file mode 100644
index 1329115..0000000
--- a/Log-Log4perl-1.18.tar.gz
+++ /dev/null
@@ -1,3 +0,0 @@
-version https://git-lfs.github.com/spec/v1
-oid sha256:f51aeb82936034d352a227513817228212e01b3f96c73a974a9a6e535bc11b98
-size 235406
diff --git a/perl-Log-Log4perl.changes b/perl-Log-Log4perl.changes
index 578dbde..8951b12 100644
--- a/perl-Log-Log4perl.changes
+++ b/perl-Log-Log4perl.changes
@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Tue Sep 16 18:56:22 CEST 2008 - lrupp@suse.de
+
+- fix rpmlint errors
+
 -------------------------------------------------------------------
 Fri Sep  5 16:12:29 CEST 2008 - ug@suse.de
 
diff --git a/perl-Log-Log4perl.spec b/perl-Log-Log4perl.spec
index 6444e6e..b7cf89a 100644
--- a/perl-Log-Log4perl.spec
+++ b/perl-Log-Log4perl.spec
@@ -17,20 +17,25 @@
 
 # norootforbuild
 
+Url:            http://search.cpan.org/perldoc?Log::Log4perl
 
 Name:           perl-Log-Log4perl
+Summary:        Log4j implementation for Perl
 License:        Artistic License
 Group:          Development/Libraries/Perl
-#Requires:
 AutoReqProv:    on
-Summary:        Log4j implementation for Perl
 Version:        1.18
-Release:        1
-Source:         Log-Log4perl-%{version}.tar.gz
+Release:        2
+# for running all tests:
+BuildRequires:  perl-DBD-CSV perl-Log-Dispatch perl-XML-DOM
+Requires:       perl = %{perl_version}
+Source:         Log-Log4perl-%{version}.tar.bz2
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
-Log4j implementation for Perl
+Log::Log4perl lets you remote-control and fine-tune the logging
+behaviour of your system from the outside. It implements the widely
+popular (Java-based) Log4j logging package in pure Perl.
 
 
 
@@ -40,51 +45,38 @@ Authors:
     Kevin Goess <cpan@goess.org>
 
 %prep
-%setup -n Log-Log4perl-%{version}
+%setup q- -n Log-Log4perl-%{version}
 # ---------------------------------------------------------------------------
 
 %build
 perl Makefile.PL
-make
+make %{?jobs:-j%jobs}
 # ---------------------------------------------------------------------------
 
+%check
+make test
+
 %install
-[ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT;
-%if %suse_version > 820
-make DESTDIR=$RPM_BUILD_ROOT \
-	 INSTALLMAN3DIR=$RPM_BUILD_ROOT/%{_mandir}/man3 \
-	 install_vendor
+%perl_make_install
 %perl_process_packlist
-%else
-install -d $RPM_BUILD_ROOT/%{perl_archlib}
-make PREFIX=$RPM_BUILD_ROOT/usr \
-         INSTALLMAN3DIR=$RPM_BUILD_ROOT/%{_mandir}/man3 \
-         install
-install -d  $RPM_BUILD_ROOT/var/adm/perl-modules
-cat $RPM_BUILD_ROOT/%{perl_archlib}/perllocal.pod | sed "s@$RPM_BUILD_ROOT@@g" > $RPM_BUILD_ROOT/var/adm/perl-modules/%{name}
-cd $RPM_BUILD_ROOT/%{perl_sitearch}/auto/Log/Log4perl
-sed "s@$RPM_BUILD_ROOT@@g" < .packlist | sort -u > .packlist.tmp
-mv .packlist.tmp .packlist
-%endif
+for file in eg/newsyslog-test eg/benchmarks/simple; do
+	sed -i "s|/usr/local/bin/perl|%_bindir/perl|g" $file
+done
 
 %files
-%defattr(-,root,root)
-%if %suse_version > 820
+%defattr(644,root,root,755)
+%doc Changes LICENSE MANIFEST README eg xml
+%doc %{_mandir}/man3/*
 %dir %{perl_vendorlib}/Log
 %{perl_vendorlib}/Log/*
 %dir %{perl_vendorarch}/auto/Log
 %dir %{perl_vendorarch}/auto/Log/Log4perl
 %{perl_vendorarch}/auto/Log/Log4perl/.packlist
 /var/adm/perl-modules/%{name}
-%else
-%dir %{perl_sitelib}/Log
-%{perl_sitelib}/Log/*
-%{perl_sitearch}/auto/Log/Log4perl/.packlist
-%endif
-%doc Changes LICENSE MANIFEST README eg xml
-%doc %{_mandir}/man3/*
 
 %changelog
+* Tue Sep 16 2008 lrupp@suse.de
+- fix rpmlint errors
 * Fri Sep 05 2008 ug@suse.de
   * Added explanation that categories and loggers are the same
   thing (thanks to Rabbit).