perl/perl-Mail-DMARC
SHA256
8
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Automatic update to v1.202.508.50 (1.20250805) #1

Merged
okurz merged 1 commits from cpanmirror/perl-Mail-DMARC:autoupdate into main 2025-09-01 16:05:28 +02:00
Conversation 2 Commits 1 Files Changed 4 +17 -11
4 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Mail-DMARC-1.20250610.tar.gz
View File

@@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:172efdf3f80f038dc794bc66797191e6fcd77b1125896d8ca1a659d8584788d5
size 808733

BIN
Mail-DMARC-1.20250805.tar.gz (Stored with Git LFS) Normal file
View File

Binary file not shown.

6
perl-Mail-DMARC.changes
View File

@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Thu Aug 28 10:33:08 UTC 2025 - Tina Müller <timueller+perl@suse.de>
- updated to 1.202.508.50 (1.20250805)
see /usr/share/doc/packages/perl-Mail-DMARC/Changes.md
-------------------------------------------------------------------
Tue Jun 10 05:35:41 UTC 2025 - Tina Müller <timueller+perl@suse.de>

16
perl-Mail-DMARC.spec
View File

@@ -1,7 +1,7 @@
#
# spec file for package perl-Mail-DMARC
#
# Copyright (c) 2025 SUSE LLC
# Copyright (c) 2025 SUSE LLC and contributors
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -18,14 +18,14 @@
%define cpan_name Mail-DMARC
Name: perl-Mail-DMARC
Version: 1.202.506.100
Version: 1.202.508.50
okurz commented 2025-09-01 10:19:38 +02:00
Review
Copy Link

I think the version in before was already bad. 20250805 is clearly a timestamp. Turning that into this is both obfuscated as well as leads to problems as 20250810 will be parsed a as lower version compared to 20250805 @tinita

I think the version in before was already bad. 20250805 is clearly a timestamp. Turning that into this is both obfuscated as well as leads to problems as 20250810 will be parsed a as *lower* version compared to 20250805 @tinita
okurz commented 2025-09-01 10:33:26 +02:00
Review
Copy Link

An example of good handling of the timestamp based version is https://src.opensuse.org/perl/perl-IPC-Run/pulls/1/files

An example of good handling of the timestamp based version is https://src.opensuse.org/perl/perl-IPC-Run/pulls/1/files
tinita commented 2025-09-01 11:09:02 +02:00
Review
Copy Link

I know it looks confusing, but I can't make my script rely on the fact that a version looks like a timestamp.
The timestamp in the version for IPC-Run is before the dot, btw, so that I don't touch at all.

First of all, 1.202.508.50 will be seen as a newer version than 1.202.506.100 because 508 is newer than 506.

So let's have a look how versions are normalized.
I added 1.20250810 to better compare with 1.20250805, so that we have both timestamps in august, to show that it is actually smaller.

So here we have three dates in ascending order:
For normalizing they are split up in triplets:

1.20250610 -> 1.202.506.10 -> 1.202.506.100
1.20250805 -> 1.202.508.05 -> 1.202.508.050 -> 1.202.508.50
1.20250810 -> 1.202.508.10 -> 1.202.508.100

So the normalized versions consist of triplets, that means the last triplet will be filled with zeroes, e.g. 1.202.508.10 is turned into 1.202.508.100. (because it is a decimal number it is originally 1.20250810000000 and so on).
For 1.202.508.05 it will be 1.202.508.050 and the leading zero in the 050 is superfluous now in the new format.

If perl module authors want timestamps as version numbers after the comma, they should rather use the dotted format in the first place, e,g. 1.2025.8.5.

I know it looks confusing, but I can't make my script rely on the fact that a version looks like a timestamp. The timestamp in the version for IPC-Run is before the dot, btw, so that I don't touch at all. First of all, `1.202.508.50` will be seen as a newer version than `1.202.506.100` because 508 is newer than 506. So let's have a look how versions are normalized. I added `1.20250810` to better compare with `1.20250805,` so that we have both timestamps in august, to show that it is actually smaller. So here we have three dates in ascending order: For normalizing they are split up in triplets: ``` 1.20250610 -> 1.202.506.10 -> 1.202.506.100 1.20250805 -> 1.202.508.05 -> 1.202.508.050 -> 1.202.508.50 1.20250810 -> 1.202.508.10 -> 1.202.508.100 ``` So the normalized versions consist of triplets, that means the last triplet will be filled with zeroes, e.g. `1.202.508.10` is turned into `1.202.508.100`. (because it is a decimal number it is originally `1.20250810000000` and so on). For `1.202.508.05` it will be `1.202.508.050` and the leading zero in the `050` is superfluous now in the new format. If perl module authors want timestamps as version numbers *after* the comma, they should rather use the dotted format in the first place, e,g. `1.2025.8.5`.
Release: 0
# 1.20250610 -> normalize -> 1.202.506.100
%define cpan_version 1.20250610
# 1.20250805 -> normalize -> 1.202.508.50
%define cpan_version 1.20250805
License: Artistic-1.0 OR GPL-1.0-or-later
Summary: Perl implementation of DMARC
URL: https://metacpan.org/release/%{cpan_name}
Source0: https://cpan.metacpan.org/authors/id/M/MB/MBRADSHAW/%{cpan_name}-%{cpan_version}.tar.gz
Source0: https://cpan.metacpan.org/authors/id/M/MS/MSIMERSON/%{cpan_name}-%{cpan_version}.tar.gz
Source1: cpanspec.yml
Source100: README.md
BuildArch: noarch
@@ -38,7 +38,7 @@ BuildRequires: perl(Email::MIME)
BuildRequires: perl(Email::Sender)
BuildRequires: perl(Email::Sender::Simple) >= 1.300.32
BuildRequires: perl(Email::Simple)
BuildRequires: perl(File::ShareDir) >= 1.0.0
BuildRequires: perl(File::ShareDir) >= 1.0
BuildRequires: perl(File::ShareDir::Install) >= 0.60
BuildRequires: perl(HTTP::Tiny)
BuildRequires: perl(IO::Compress::Gzip)
@@ -46,7 +46,7 @@ BuildRequires: perl(IO::Compress::Zip)
BuildRequires: perl(IO::Socket::SSL)
BuildRequires: perl(IO::Uncompress::Gunzip)
BuildRequires: perl(IO::Uncompress::Unzip)
BuildRequires: perl(Module::Build) >= 0.3601
BuildRequires: perl(Module::Build) >= 0.360.100
BuildRequires: perl(Module::Load)
BuildRequires: perl(Net::DNS::Resolver)
BuildRequires: perl(Net::DNS::Resolver::Mock)
@@ -67,7 +67,7 @@ Requires: perl(Email::MIME)
Requires: perl(Email::Sender)
Requires: perl(Email::Sender::Simple) >= 1.300.32
Requires: perl(Email::Simple)
Requires: perl(File::ShareDir) >= 1.0.0
Requires: perl(File::ShareDir) >= 1.0
Requires: perl(HTTP::Tiny)
Requires: perl(IO::Compress::Gzip)
Requires: perl(IO::Compress::Zip)