forked from pool/perl-SDL
Dirk Stoecker
7f62694313
- Add 308.patch: Fix reference-counting in set_event_filter (gh#PerlGameDev/SDL#308). OBS-URL: https://build.opensuse.org/request/show/1167869 OBS-URL: https://build.opensuse.org/package/show/devel:languages:perl/perl-SDL?expand=0&rev=27
31 lines
1.1 KiB
Diff
31 lines
1.1 KiB
Diff
From fbf151a7481a5fda88bfe766d826fe55476cf4af Mon Sep 17 00:00:00 2001
|
|
From: Colin Watson <cjwatson@debian.org>
|
|
Date: Thu, 28 Mar 2024 13:21:47 +0000
|
|
Subject: [PATCH] Fix reference-counting in set_event_filter
|
|
|
|
This previously resulted in the following test failure with Perl 5.38.2
|
|
on Debian unstable (https://bugs.debian.org/1064761):
|
|
|
|
t/core_events.t ................. 1/? Can't use an undefined value as a subroutine reference during global destruction.
|
|
t/core_events.t ................. Dubious, test returned 22 (wstat 5632, 0x1600)
|
|
All 691 subtests passed
|
|
(less 1 skipped subtest: 690 okay)
|
|
---
|
|
src/Core/Events.xs | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/Core/Events.xs b/src/Core/Events.xs
|
|
index faa7cfe6..0b99f8a9 100644
|
|
--- a/src/Core/Events.xs
|
|
+++ b/src/Core/Events.xs
|
|
@@ -102,7 +102,8 @@ void
|
|
events_set_event_filter(callback)
|
|
SV* callback
|
|
CODE:
|
|
- eventfiltersv = callback;
|
|
+ SvREFCNT_dec(eventfiltersv);
|
|
+ eventfiltersv = SvREFCNT_inc_simple(callback);
|
|
SDL_SetEventFilter((SDL_EventFilter) eventfilter_cb);
|
|
|
|
AV *
|