perl/perl-Text-Kakasi
SHA256
8
0
Fork 2
forked from pool/perl-Text-Kakasi
Code Pull Requests 1 Activity

fix: add kakasi-devel to buildrequires #1

Closed
alessio.biancalana wants to merge 3 commits from alessio.biancalana/perl-Text-Kakasi:fix-kakasi-devel-builddep into main
pull from: alessio.biancalana/perl-Text-Kakasi:fix-kakasi-devel-builddep
merge into: perl:main
Conversation 4 Commits 3 Files Changed 2 +21 -14
alessio.biancalana commented 2025-08-22 10:16:24 +02:00
First-time contributor
Copy Link

Adding kakasi-devel to buildrequires fixes a number of issues with the actual building of the package.

Adding kakasi-devel to buildrequires fixes a number of issues with the actual building of the package.
alessio.biancalana added 2 commits 2025-08-22 10:16:24 +02:00
fix: add kakasi-devel to buildrequires 9a7c566b66
fix: document spec-cleaner applying in the changes file 0ddf804b43
autogits-devel requested review from dstoecker 2025-08-22 10:16:44 +02:00
autogits-devel requested review from kraih 2025-08-22 10:16:44 +02:00
autogits-devel requested review from okurz 2025-08-22 10:16:44 +02:00
autogits-devel requested review from rjschwei 2025-08-22 10:16:44 +02:00
autogits-devel requested review from smithfarm 2025-08-22 10:16:45 +02:00
autogits-devel requested review from tinita 2025-08-22 10:16:45 +02:00
tinita requested changes 2025-08-22 10:26:22 +02:00
tinita left a comment
Owner
Copy Link

Hi @alessio.biancalana kakasi-devel is already a BuildRequires dependency.
But in general, any manually added dependencies should be added to the cpanspec.yml file, so that if we regenerate the spec with cpanspec (for a new release or some other reaon) any manual additions don't get lost.
I can do this later today.

Hi @alessio.biancalana kakasi-devel is already a BuildRequires dependency. But in general, any manually added dependencies should be added to the `cpanspec.yml` file, so that if we regenerate the spec with `cpanspec` (for a new release or some other reaon) any manual additions don't get lost. I can do this later today.
alessio.biancalana added 1 commit 2025-08-22 10:56:02 +02:00
fix: avoid cat-ting a headers file previously printed for debug purposes b76f2c78be
autogits-devel requested review from tinita 2025-08-22 10:56:45 +02:00
alessio.biancalana commented 2025-08-22 10:59:28 +02:00
Author
First-time contributor
Copy Link

Hi @tinita, where can I find the cpanspec.yml file so I can check it out next time I'm uncertain about other buildrequires? Also, is the Requires: kakasi line fine or should I drop that as well?

Hi @tinita, where can I find the `cpanspec.yml` file so I can check it out next time I'm uncertain about other buildrequires? Also, is the `Requires: kakasi` line fine or should I drop that as well?
tinita commented 2025-08-27 20:45:00 +02:00
Owner
Copy Link

Sorry for the delay, see #2 please

Sorry for the delay, see #2 please
alessio.biancalana commented 2025-08-27 20:47:40 +02:00
Author
First-time contributor
Copy Link

Closing in favor of #2, a much better approach, thanks @tinita

Closing in favor of #2, a much better approach, thanks @tinita

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
dstoecker
kraih
okurz
rjschwei
smithfarm
tinita
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm autogits-devel kraih mlschroe okurz rjschwei smithfarm tinita
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: perl/perl-Text-Kakasi#1
No description provided.
Delete Branch "alessio.biancalana/perl-Text-Kakasi:fix-kakasi-devel-builddep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?