perl/perl-Text-Kakasi
SHA256
8
0
Fork 2
forked from pool/perl-Text-Kakasi
Code Pull Requests Activity

fix: mention README.md in the specfile #3

Merged
okurz merged 1 commits from alessio.biancalana/perl-Text-Kakasi:readme-specfile into main 2025-09-01 16:04:28 +02:00
Conversation 7 Commits 1 Files Changed 1 +1
alessio.biancalana commented 2025-09-01 10:42:19 +02:00
Contributor
Copy Link

Factory complains (rightfully so) that README.md isn't mentioned in the specfile. Addressing that promptly.

Factory complains (rightfully so) that README.md isn't mentioned in the specfile. Addressing that promptly.
alessio.biancalana added 1 commit 2025-09-01 10:42:20 +02:00
fix: mention README.md in the specfile 60cce58ad7
autogits-devel requested review from dstoecker 2025-09-01 10:42:38 +02:00
autogits-devel requested review from kraih 2025-09-01 10:42:38 +02:00
autogits-devel requested review from okurz 2025-09-01 10:42:39 +02:00
autogits-devel requested review from rjschwei 2025-09-01 10:42:42 +02:00
autogits-devel requested review from smithfarm 2025-09-01 10:42:43 +02:00
autogits-devel requested review from tinita 2025-09-01 10:42:44 +02:00
okurz requested changes 2025-09-01 10:50:26 +02:00
okurz left a comment
Owner
Copy Link

I think it would be better to specify that in https://src.opensuse.org/alessio.biancalana/perl-Text-Kakasi/src/branch/readme-specfile/cpanspec.yml#L7 so that the spec file can be generated by cpanspec. @tinita knows more details

I think it would be better to specify that in https://src.opensuse.org/alessio.biancalana/perl-Text-Kakasi/src/branch/readme-specfile/cpanspec.yml#L7 so that the spec file can be generated by cpanspec. @tinita knows more details
alessio.biancalana commented 2025-09-01 10:59:16 +02:00
Author
Contributor
Copy Link

@okurz thanks for highlighting this, cpanspec.yml was indeed written by @tinita last week 😅 I tried to look into other packages but none of them has the sources section populated tho

@okurz thanks for highlighting this, `cpanspec.yml` was indeed written by @tinita last week 😅 I tried to look into other packages but none of them has the `sources` section populated tho
tinita commented 2025-09-01 11:19:32 +02:00
Owner
Copy Link

Ok, so the thing is, I generated the spec file for this module with the old version format in order to get that change through without any unrelated change. But only with the new --dlp switch cpanspec will add the Readme.md to the specfile, so I missed that one. So I would approve this PR now and after that I will convert the module to the new version.

Ok, so the thing is, I generated the spec file for this module with the old version format in order to get that change through without any unrelated change. But only with the new `--dlp` switch cpanspec will add the Readme.md to the specfile, so I missed that one. So I would approve this PR now and after that I will convert the module to the new version.
👍 1
tinita approved these changes 2025-09-01 11:20:23 +02:00
tinita commented 2025-09-01 11:21:09 +02:00
Owner
Copy Link

@okurz every module in devel:languages:perl has this Readme file now

@okurz every module in devel:languages:perl has this Readme file now
tinita requested review from okurz 2025-09-01 11:21:17 +02:00
alessio.biancalana commented 2025-09-01 13:53:49 +02:00
Author
Contributor
Copy Link

@tinita thanks for the thorough explanation 😄

@tinita thanks for the thorough explanation 😄
okurz merged commit 60cce58ad7 into main 2025-09-01 16:04:28 +02:00
tinita commented 2025-09-01 18:28:35 +02:00
Owner
Copy Link

https://build.opensuse.org/requests/1302238

https://build.opensuse.org/requests/1302238
Sign in to join this conversation.
Reviewers
No Reviewers
dstoecker
kraih
rjschwei
smithfarm
tinita
okurz
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm autogits-devel kraih mlschroe okurz rjschwei smithfarm tinita
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: perl/perl-Text-Kakasi#3
No description provided.
Delete Branch "alessio.biancalana/perl-Text-Kakasi:readme-specfile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?