Thanks, that makes sense.
You're right that having the same badge link to different targets depending on the state can lead to inconsistent behavior.
I’ll update the approach to keep the…
Thanks for pointing this out.
I commented it out earlier while debugging the unreachable code issue caused by the return statement, but I agree that leaving commented code is not ideal.
I’ll…
Hi,
I’ve implemented the fallback logic as discussed in #94. Would appreciate your feedback.
Thanks!
Hi,
I’ve gone through the issue in detail and also reviewed the related pull requests #97 and #98.
From my understanding:
- #97 improves the API by allowing format selection via query…
@dgarcia Thanks for the feedback!
I have addressed all the review comments:
- Applied go fmt for consistent indentation (tabs instead of spaces)
- Removed fallback logic in redismock to…
Understood, removing the error fallback so the process crashes naturally if there's an issue parsing the test data bzip. Will fix this along with the indentation changes.
Hi @danigm, thank you for the feedback! I will fix the indentation to use tabs instead of spaces. Will push the changes shortly.
Hi,
I’ve implemented a minimal root index page based on the previous discussion and feedback on keeping it simple.
PR: #193
It serves a static HTML page at / with basic usage…
Hi, I have implemented a solution for this issue by introducing a --test-run mode to allow running the service without a Redis instance.
This includes:
- Adding a RedisClient interface -…