Accepting request 616457 from home:zhangxiaofei:branches:GNOME:Factory

- Add accountsservice-missing-users-on-gdm-login.patch: Don't abort
  loading users when an /etc/shadow entry found missing
  (boo#1090003 fdo#106904).

OBS-URL: https://build.opensuse.org/request/show/616457
OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/accountsservice?expand=0&rev=116

accountsservice-missing-users-on-gdm-login.patch

@@ -0,0 +1,36 @@
+From c9503bcb40c21da08b7938279117d68ec37ac1f1 Mon Sep 17 00:00:00 2001
+From: Felix Zhang <fezhang@suse.com>
+Date: Wed, 13 Jun 2018 11:05:52 +0800
+Subject: [PATCH] daemon: don't abort loading users even if missing shadow
+ entries
+
+Some system accounts, e.g. sshd have no entries in /etc/shadow
+because they are created prior to /etc/shadow and have no passwords.
+
+Right now load_entries aborts iterating through /etc/passwd entries
+if it fails to find the corresponding /etc/shadow entry, ignoring
+all the users behind it, making those users missing from the gdm
+login screen user list.
+
+https://bugs.freedesktop.org/show_bug.cgi?id=106904
+---
+ src/daemon.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/daemon.c b/src/daemon.c
+index e711a46..2851ed6 100644
+--- a/src/daemon.c
++++ b/src/daemon.c
+@@ -235,8 +235,8 @@ entry_generator_fgetpwent (Daemon       *daemon,
+ 
+                         if (shadow_entry_buffers != NULL) {
+                             *spent = &shadow_entry_buffers->spbuf;
+-                            return pwent;
+                         }
++                        return pwent;
+                 }
+         }
+ 
+-- 
+2.13.7
+

accountsservice.changes

@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Wed Jun 13 06:00:22 UTC 2018 - fezhang@suse.com
+
+- Add accountsservice-missing-users-on-gdm-login.patch: Don't abort
+  loading users when an /etc/shadow entry found missing
+  (boo#1090003 fdo#106904).
+
 -------------------------------------------------------------------
 Sun May 13 23:59:22 UTC 2018 - luc14n0@linuxmail.org
 

accountsservice.spec

@@ -30,6 +30,8 @@ Source:         http://www.freedesktop.org/software/accountsservice/%{name}-%{ve
 Patch0:         accountsservice-sysconfig.patch
 # PATCH-FIX-OPENSUSE accountsservice-filter-suse-accounts.patch vuntz@opensuse.org -- Filter out some system users that are specific to openSUSE
 Patch1:         accountsservice-filter-suse-accounts.patch
+# PATCH-FIX-UPSTREAM accountsservice-missing-users-on-gdm-login.patch boo#1090003 fdo#106904 fezhang@suse.com -- Don't abort loading users when an /etc/shadow entry found missing
+Patch2:         accountsservice-missing-users-on-gdm-login.patch
 ## SLE-only patches start at 1000
 # PATCH-FEATURE-SLE as-fate318433-prevent-same-account-multi-logins.patch fate#318433 cxiong@suse.com -- prevent multiple simultaneous login.
 Patch1000:      as-fate318433-prevent-same-account-multi-logins.patch
@@ -98,6 +100,7 @@ querying and manipulating user account information.
 %setup -q
 %patch0 -p1
 %patch1 -p1
+%patch2 -p1
 # Sle-only patches start at 1000
 %if !0%{?is_opensuse}
 %patch1000 -p1