Marcus Meissner
5439477a49
- Update to git snapshot dated 21 Sep 2015.
- Added:
* 0001-Install-the-libraries-to-the-appropriate-directory.patch
* 0002-setfacl.1-fix-typo-inclu-de-include.patch
* 0003-test-fix-insufficient-quoting-of.patch
* 0004-Makefile-rename-configure.in-to-configure.ac.patch
* 0005-Bad-markup-in-acl.5-page.patch
* 0006-.gitignore-ignore-and-config.h.in.patch
* 0007-Use-autoreconf-rather-than-autoconf-to-regenerate-th.patch
* 0008-libacl-Make-sure-that-acl_from_text-always-sets-errn.patch
* 0009-libacl-fix-SIGSEGV-of-getfacl-e-on-overly-long-group.patch
* 0010-punt-debian-rpm-packaging-logic.patch
* 0011-move-gettext-logic-into-misc.h.patch
* 0012-test-make-running-parallel-out-of-tree-safe.patch
* 0013-modernize-build-system.patch
* 0014-po-regenerate-files-after-move.patch
* 0015-build-drop-aclincludedir-use-pkgincludedir.patch
* 0016-build-make-use-of-an-aux-dir-to-stow-away-helper-scr.patch
* 0017-build-ship-a-pkgconfig-file-for-libacl.patch
* 0018-read_acl_-comments-seq-rename-line-to-lineno.patch
* 0019-read_acl_-comments-seq-switch-to-next_line.patch
* 0020-telldir-return-value-and-seekdir-second-parameters-a.patch
* 0021-mark-libmisc-funcs-as-hidden-so-they-are-not-exporte.patch
* 0022-add-__acl_-prefixes-to-internal-symbols.patch
* 0023-cp.test-Check-permissions-of-the-right-file.patch
* 0024-libacl-acl_set_file-Remove-unnecesary-racy-check.patch
* 0025-fix-compilation-with-latest-xattr-git.patch
* 0026-getfacl-Fix-memory-leak.patch
* 0027-Fix-the-display-block-nesting-in-acl.5.patch
* 0028-setfacl-man-page-Minor-wording-improvements.patch
OBS-URL: https://build.opensuse.org/request/show/347209
OBS-URL: https://build.opensuse.org/package/show/Base:System/acl?expand=0&rev=43
43 lines
1.2 KiB
Diff
43 lines
1.2 KiB
Diff
From 124e431e677f5ed3c45f71105a6770ceb96199dd Mon Sep 17 00:00:00 2001
|
|
From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
|
|
Date: Mon, 13 Apr 2015 11:56:05 +0200
|
|
Subject: [PATCH 24/34] libacl: acl_set_file: Remove unnecesary racy check
|
|
|
|
Only directories can have default acls. This is checked in the kernel, and
|
|
unnecessarily also in acl_set_file. There is a window between checking the file
|
|
type and setting the acl, so the check in acl_set_file isn't even safe. Remove
|
|
it.
|
|
|
|
Reported by Lennart Poettering <lpoetter@redhat.com>.
|
|
---
|
|
libacl/acl_set_file.c | 13 -------------
|
|
1 file changed, 13 deletions(-)
|
|
|
|
diff --git a/libacl/acl_set_file.c b/libacl/acl_set_file.c
|
|
index 6821851..a7e368f 100644
|
|
--- a/libacl/acl_set_file.c
|
|
+++ b/libacl/acl_set_file.c
|
|
@@ -54,19 +54,6 @@ acl_set_file(const char *path_p, acl_type_t type, acl_t acl)
|
|
return -1;
|
|
}
|
|
|
|
- if (type == ACL_TYPE_DEFAULT) {
|
|
- struct stat st;
|
|
-
|
|
- if (stat(path_p, &st) != 0)
|
|
- return -1;
|
|
-
|
|
- /* Only directories may have default ACLs. */
|
|
- if (!S_ISDIR(st.st_mode)) {
|
|
- errno = EACCES;
|
|
- return -1;
|
|
- }
|
|
- }
|
|
-
|
|
ext_acl_p = __acl_to_xattr(acl_obj_p, &size);
|
|
if (!ext_acl_p)
|
|
return -1;
|
|
--
|
|
2.5.2
|
|
|