- Remove hackish modprobe install scripts for auto-loading OSS and sequencer modules (bsc#1136562); it's invoked from systemd unit file included in alsa-utils now - Backport upstream fixes: 0001-pcm-direct-Add-generic-hw_ptr_alignment-function-for.patch 0002-pcm-dshare-Added-hw_ptr_alignment-option-in-configur.patch 0003-pcm-dsnoop-Added-hw_ptr_alignment-option-in-configur.patch 0004-pcm-file-add-support-for-infile-reading-in-non-inter.patch 0005-pcm-file-use-snd_pcm_file_areas_read_infile-for-read.patch 0006-pcm-file-add-missing-unlock-on-early-return.patch 0007-ucm-Add-UCM-profile-for-CX2072X-codec-on-Baytrail-Ch.patch 0008-pcm-add-mmap_begin-callback-to-snd_pcm_fast_ops_t-ap.patch 0009-pcm-file-add-infile-read-support-for-mmap-mode.patch 0010-aserver-fix-resource-leak-coverity.patch 0011-src-conf.c-add-missing-va_end-call-coverity.patch 0012-config-parse_string-fix-the-dynamic-buffer-allocatio.patch 0013-control_shm-remove-duplicate-code-coverity.patch 0014-control_shm-add-missing-socket-close-to-the-error-pa.patch 0015-pcm-fix-memory-leak-in-_snd_pcm_parse_config_chmaps-.patch 0016-pcm_file-call-pclose-correctly-for-popen-coverity.patch 0017-pcm_hw-close-file-descriptor-in-the-error-path-in-sn.patch 0018-rawmidi-use-snd_dlobj_cache_get2-in-rawmidi-open-cov.patch 0019-rawmidi_hw-add-sanity-check-for-the-invalid-stream-a.patch 0020-topology-various-coverity-fixes.patch 0021-ucm-coverity-fixes.patch 0022-pcm_file-coverity-fixes-including-double-locking.patch 0023-topology-next-round-of-coverity-fixes.patch 0024-pcm_file-another-locking-fix-coverity.patch 0025-ucm-another-coverity-fix-in-uc_mgr_config_load.patch - Drop the downstream CX2072X UCM profile, which is replaced with OBS-URL: https://build.opensuse.org/request/show/706089 OBS-URL: https://build.opensuse.org/package/show/multimedia:libs/alsa?expand=0&rev=253
138 lines
4.9 KiB
Diff
138 lines
4.9 KiB
Diff
From 63ba5243ab7a33b77be5b65c0a8a2a0d5e26983f Mon Sep 17 00:00:00 2001
|
|
From: Vanitha Channaiah <vanitha.channaiah@in.bosch.com>
|
|
Date: Wed, 15 May 2019 11:56:32 +0530
|
|
Subject: [PATCH 01/25] pcm: direct: Add generic hw_ptr_alignment function for
|
|
dmix, dshare and dsnoop
|
|
|
|
Move the code snd_pcm_direct_reset_slave_ptr() from pcm_dmix.c
|
|
to pcm_direct.c and its header so that the helper function can be
|
|
re-used by other direct-pcm plugins.
|
|
There is no change in the behavior or the functionality.
|
|
|
|
Signed-off-by: Vanitha Channaiah <vanitha.channaiah@in.bosch.com>
|
|
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
|
---
|
|
src/pcm/pcm_direct.c | 19 +++++++++++++++++++
|
|
src/pcm/pcm_direct.h | 8 ++++++++
|
|
src/pcm/pcm_dmix.c | 25 ++-----------------------
|
|
3 files changed, 29 insertions(+), 23 deletions(-)
|
|
|
|
diff --git a/src/pcm/pcm_direct.c b/src/pcm/pcm_direct.c
|
|
index 666a8ce5b130..411a035b32ed 100644
|
|
--- a/src/pcm/pcm_direct.c
|
|
+++ b/src/pcm/pcm_direct.c
|
|
@@ -2040,3 +2040,22 @@ int snd_pcm_direct_parse_open_conf(snd_config_t *root, snd_config_t *conf,
|
|
|
|
return 0;
|
|
}
|
|
+
|
|
+void snd_pcm_direct_reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix)
|
|
+{
|
|
+ dmix->slave_appl_ptr = dmix->slave_hw_ptr = *dmix->spcm->hw.ptr;
|
|
+
|
|
+ if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDUP ||
|
|
+ (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO &&
|
|
+ pcm->buffer_size <= pcm->period_size * 2))
|
|
+ dmix->slave_appl_ptr =
|
|
+ ((dmix->slave_appl_ptr + dmix->slave_period_size - 1) /
|
|
+ dmix->slave_period_size) * dmix->slave_period_size;
|
|
+ else if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDDOWN ||
|
|
+ (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO &&
|
|
+ (dmix->slave_period_size * SEC_TO_MS) /
|
|
+ pcm->rate < LOW_LATENCY_PERIOD_TIME))
|
|
+ dmix->slave_appl_ptr = dmix->slave_hw_ptr =
|
|
+ ((dmix->slave_hw_ptr / dmix->slave_period_size) *
|
|
+ dmix->slave_period_size);
|
|
+}
|
|
diff --git a/src/pcm/pcm_direct.h b/src/pcm/pcm_direct.h
|
|
index da5e280e711d..a71aab13afa9 100644
|
|
--- a/src/pcm/pcm_direct.h
|
|
+++ b/src/pcm/pcm_direct.h
|
|
@@ -24,6 +24,11 @@
|
|
|
|
#define DIRECT_IPC_SEMS 1
|
|
#define DIRECT_IPC_SEM_CLIENT 0
|
|
+/* Seconds representing in Milli seconds */
|
|
+#define SEC_TO_MS 1000
|
|
+/* slave_period time for low latency requirements in ms */
|
|
+#define LOW_LATENCY_PERIOD_TIME 10
|
|
+
|
|
|
|
typedef void (mix_areas_t)(unsigned int size,
|
|
volatile void *dst, void *src,
|
|
@@ -257,6 +262,8 @@ struct snd_pcm_direct {
|
|
snd1_pcm_direct_get_chmap
|
|
#define snd_pcm_direct_set_chmap \
|
|
snd1_pcm_direct_set_chmap
|
|
+#define snd_pcm_direct_reset_slave_ptr \
|
|
+ snd1_pcm_direct_reset_slave_ptr
|
|
|
|
int snd_pcm_direct_semaphore_create_or_connect(snd_pcm_direct_t *dmix);
|
|
|
|
@@ -341,6 +348,7 @@ int snd_pcm_direct_slave_recover(snd_pcm_direct_t *direct);
|
|
int snd_pcm_direct_client_chk_xrun(snd_pcm_direct_t *direct, snd_pcm_t *pcm);
|
|
int snd_timer_async(snd_timer_t *timer, int sig, pid_t pid);
|
|
struct timespec snd_pcm_hw_fast_tstamp(snd_pcm_t *pcm);
|
|
+void snd_pcm_direct_reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix);
|
|
|
|
struct snd_pcm_direct_open_conf {
|
|
key_t ipc_key;
|
|
diff --git a/src/pcm/pcm_dmix.c b/src/pcm/pcm_dmix.c
|
|
index c5592cdba3c4..dcde40d9976e 100644
|
|
--- a/src/pcm/pcm_dmix.c
|
|
+++ b/src/pcm/pcm_dmix.c
|
|
@@ -55,9 +55,6 @@ const char *_snd_module_pcm_dmix = "";
|
|
#define STATE_RUN_PENDING 1024
|
|
#endif
|
|
|
|
-#define SEC_TO_MS 1000 /* Seconds representing in Milli seconds */
|
|
-#define LOW_LATENCY_PERIOD_TIME 10 /* slave_period time for low latency requirements in ms */
|
|
-
|
|
/*
|
|
*
|
|
*/
|
|
@@ -560,30 +557,12 @@ static int snd_pcm_dmix_hwsync(snd_pcm_t *pcm)
|
|
}
|
|
}
|
|
|
|
-static void reset_slave_ptr(snd_pcm_t *pcm, snd_pcm_direct_t *dmix)
|
|
-{
|
|
- dmix->slave_appl_ptr = dmix->slave_hw_ptr = *dmix->spcm->hw.ptr;
|
|
-
|
|
- if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDUP ||
|
|
- (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO &&
|
|
- pcm->buffer_size <= pcm->period_size * 2))
|
|
- dmix->slave_appl_ptr =
|
|
- ((dmix->slave_appl_ptr + dmix->slave_period_size - 1)
|
|
- / dmix->slave_period_size) * dmix->slave_period_size;
|
|
- else if (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_ROUNDDOWN ||
|
|
- (dmix->hw_ptr_alignment == SND_PCM_HW_PTR_ALIGNMENT_AUTO &&
|
|
- (dmix->slave_period_size * SEC_TO_MS) / pcm->rate < LOW_LATENCY_PERIOD_TIME))
|
|
- dmix->slave_appl_ptr = dmix->slave_hw_ptr =
|
|
- ((dmix->slave_hw_ptr / dmix->slave_period_size) *
|
|
- dmix->slave_period_size);
|
|
-}
|
|
-
|
|
static int snd_pcm_dmix_reset(snd_pcm_t *pcm)
|
|
{
|
|
snd_pcm_direct_t *dmix = pcm->private_data;
|
|
dmix->hw_ptr %= pcm->period_size;
|
|
dmix->appl_ptr = dmix->last_appl_ptr = dmix->hw_ptr;
|
|
- reset_slave_ptr(pcm, dmix);
|
|
+ snd_pcm_direct_reset_slave_ptr(pcm, dmix);
|
|
return 0;
|
|
}
|
|
|
|
@@ -592,7 +571,7 @@ static int snd_pcm_dmix_start_timer(snd_pcm_t *pcm, snd_pcm_direct_t *dmix)
|
|
int err;
|
|
|
|
snd_pcm_hwsync(dmix->spcm);
|
|
- reset_slave_ptr(pcm, dmix);
|
|
+ snd_pcm_direct_reset_slave_ptr(pcm, dmix);
|
|
err = snd_timer_start(dmix->timer);
|
|
if (err < 0)
|
|
return err;
|
|
--
|
|
2.16.4
|
|
|