From: Dave Plater Date: Thu 22 Feb 12:11:43 SAST 2018 Subject: Fix various build errors found by rpmlint References: Upstream: reported to audacity devel list. I: Program is using implicit definitions of functions getting pointers or implemented by macros. These functions need to use their correct prototypes to allow correct argument passing on e.g. x86_64 . - Implicit memory/string functions need #include . - Implicit *printf functions need #include . - Implicit *printf functions need #include . - Implicit *read* functions need #include . - Implicit *recv* functions need #include . W: audacity implicit-pointer-decl pm_linux/finddefault.c:16 I: Program is using uninitialized variables. Note the difference between "is used" and "may be used" W: audacity uninitialized-variable ../include/audacity/EffectAutomationParameters.h:122 W: audacity uninitialized-variable sse.h:19 I: Program uses operation a <= b <= c, which is not well defined. E: audacity mathmeaning SplashDialog.cpp:148 Index: audacity-Audacity-2.4.1/lib-src/portmidi/pm_linux/finddefault.c =================================================================== --- audacity-Audacity-2.4.1.orig/lib-src/portmidi/pm_linux/finddefault.c 2020-05-19 11:43:53.000000000 +0200 +++ audacity-Audacity-2.4.1/lib-src/portmidi/pm_linux/finddefault.c 2020-06-08 11:50:49.379072582 +0200 @@ -5,6 +5,8 @@ #include #include #include +#include +#include #include "portmidi.h" #define STRING_MAX 256 Index: audacity-Audacity-2.4.1/include/audacity/EffectAutomationParameters.h =================================================================== --- audacity-Audacity-2.4.1.orig/include/audacity/EffectAutomationParameters.h 2020-05-19 11:43:53.000000000 +0200 +++ audacity-Audacity-2.4.1/include/audacity/EffectAutomationParameters.h 2020-06-08 11:50:49.379072582 +0200 @@ -135,7 +135,7 @@ public: bool ReadFloat(const wxString & key, float *pf) const { - double d = *pf; + double d = (float) *pf; bool success = Read(key, &d); if (success) {