From 68aabe785c92f144ef9aa8154cc4a19c068b15ec990fbd1b149058a3ab1daa9e Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Mon, 2 Oct 2017 08:55:36 +0000 Subject: [PATCH] Accepting request 529877 from home:marxin:branches:devel:gcc - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. - Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. OBS-URL: https://build.opensuse.org/request/show/529877 OBS-URL: https://build.opensuse.org/package/show/devel:gcc/binutils?expand=0&rev=253 --- binutils-2.29-branch.diff | 157 +++++++++++++++++++++++++++++++- binutils.changes | 5 + cross-aarch64-binutils.changes | 5 + cross-arm-binutils.changes | 5 + cross-avr-binutils.changes | 5 + cross-epiphany-binutils.changes | 5 + cross-hppa-binutils.changes | 5 + cross-hppa64-binutils.changes | 5 + cross-i386-binutils.changes | 5 + cross-ia64-binutils.changes | 5 + cross-m68k-binutils.changes | 5 + cross-mips-binutils.changes | 5 + cross-ppc-binutils.changes | 5 + cross-ppc64-binutils.changes | 5 + cross-ppc64le-binutils.changes | 5 + cross-riscv64-binutils.changes | 5 + cross-rx-binutils.changes | 5 + cross-s390-binutils.changes | 5 + cross-s390x-binutils.changes | 5 + cross-sparc-binutils.changes | 5 + cross-sparc64-binutils.changes | 5 + cross-spu-binutils.changes | 5 + cross-x86_64-binutils.changes | 5 + 23 files changed, 262 insertions(+), 5 deletions(-) diff --git a/binutils-2.29-branch.diff b/binutils-2.29-branch.diff index 6afbe81..377c8f0 100644 --- a/binutils-2.29-branch.diff +++ b/binutils-2.29-branch.diff @@ -1,8 +1,14 @@ diff --git a/bfd/ChangeLog b/bfd/ChangeLog -index 417ed273ab..d09a3c6568 100644 +index 417ed273ab..8f8117dcb4 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog -@@ -1,3 +1,31 @@ +@@ -1,3 +1,37 @@ ++2017-09-28 Alan Modra ++ ++ PR 22220 ++ * elflink.c (_bfd_elf_merge_symbol): Set non_ir_ref_dynamic in ++ a case where plugin_notice isn't called. ++ +2017-09-26 H.J. Lu + + PR ld/22199 @@ -90,6 +96,27 @@ index 80dd791d25..1f6dfb89bf 100644 } offset += plt_entry_size; } +diff --git a/bfd/elflink.c b/bfd/elflink.c +index 02713a5956..ee3cc6b8b4 100644 +--- a/bfd/elflink.c ++++ b/bfd/elflink.c +@@ -1234,6 +1234,16 @@ _bfd_elf_merge_symbol (bfd *abfd, + olddyn = (oldsec->symbol->flags & BSF_DYNAMIC) != 0; + } + ++ /* Handle a case where plugin_notice won't be called and thus won't ++ set the non_ir_ref flags on the first pass over symbols. */ ++ if (oldbfd != NULL ++ && (oldbfd->flags & BFD_PLUGIN) != (abfd->flags & BFD_PLUGIN) ++ && newdyn != olddyn) ++ { ++ h->root.non_ir_ref_dynamic = TRUE; ++ hi->root.non_ir_ref_dynamic = TRUE; ++ } ++ + /* NEWDEF and OLDDEF indicate whether the new or old symbol, + respectively, appear to be a definition rather than reference. */ + diff --git a/bfd/version.h b/bfd/version.h index 3405e424f4..bc0fbb7648 100644 --- a/bfd/version.h @@ -178,10 +205,15 @@ index c71dca4351..25221ae2af 100644 run_dump_test "mips-gp32-fp32-pic" diff --git a/gold/ChangeLog b/gold/ChangeLog -index 6071f8977a..0fc54ddf71 100644 +index 6071f8977a..32c0e21f54 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog -@@ -1,3 +1,14 @@ +@@ -1,3 +1,19 @@ ++2017-09-28 Alan Modra ++ ++ * powerpc.cc (Target_powerpc<64,*>::powerpc_info): Set ++ is_default_stack_executable false. ++ +2017-08-03 James Clarke + + * options.h (General_options): Set a non-NULL second help string @@ -211,9 +243,27 @@ index 576b2a3c53..4a802cf41f 100644 DEFINE_string(retain_symbols_file, options::TWO_DASHES, '\0', NULL, N_("keep only symbols listed in this file"), N_("FILE")); diff --git a/gold/powerpc.cc b/gold/powerpc.cc -index 629da4f8a1..ba20ef1ad7 100644 +index 629da4f8a1..22590c1e43 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc +@@ -1618,7 +1618,7 @@ Target::Target_info Target_powerpc<64, true>::powerpc_info = + false, // has_make_symbol + true, // has_resolve + false, // has_code_fill +- true, // is_default_stack_executable ++ false, // is_default_stack_executable + false, // can_icf_inline_merge_sections + '\0', // wrap_char + "/usr/lib/ld.so.1", // dynamic_linker +@@ -1646,7 +1646,7 @@ Target::Target_info Target_powerpc<64, false>::powerpc_info = + false, // has_make_symbol + true, // has_resolve + false, // has_code_fill +- true, // is_default_stack_executable ++ false, // is_default_stack_executable + false, // can_icf_inline_merge_sections + '\0', // wrap_char + "/usr/lib/ld.so.1", // dynamic_linker @@ -3065,11 +3065,17 @@ Target_powerpc::Branch_info::make_stub( target->glink_section()->add_global_entry(gsym); else @@ -258,3 +308,100 @@ index 629da4f8a1..ba20ef1ad7 100644 if (target->stub_tables().size() != 0) stub_table = target->stub_tables()[0]; } +diff --git a/ld/ChangeLog b/ld/ChangeLog +index 73e05b618e..ba67e20bf9 100644 +--- a/ld/ChangeLog ++++ b/ld/ChangeLog +@@ -1,3 +1,11 @@ ++2017-09-28 Alan Modra ++ ++ * testsuite/ld-plugin/pr22220.h, ++ * testsuite/ld-plugin/pr22220lib.cc, ++ * testsuite/ld-plugin/pr22220lib.ver, ++ * testsuite/ld-plugin/pr22220main.cc: New test. ++ * testsuite/ld-plugin/lto.exp: Run it. ++ + 2017-09-19 Nick Clifton + + 2.29.1 Release +diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp +index f0bc345f2c..6b7ad536fb 100644 +--- a/ld/testsuite/ld-plugin/lto.exp ++++ b/ld/testsuite/ld-plugin/lto.exp +@@ -295,6 +295,12 @@ set lto_link_elf_tests [list \ + [list "Build pr21382.so" \ + "-shared" "-O2 -fpic" \ + {pr21382b.c} {} "pr21382.so" "c"] \ ++ [list {Build pr22220lib.so} \ ++ {-shared -Wl,--version-script=pr22220lib.ver} {-fPIC} \ ++ {pr22220lib.cc} {} {pr22220lib.so} {c++}] \ ++ [list {Build pr22220main.o} \ ++ {} {-flto} \ ++ {pr22220main.cc} {} {} {c++}] \ + ] + + # Check final symbols in executables. +@@ -396,6 +402,12 @@ set lto_run_elf_shared_tests [list \ + [list "Run pr21382" \ + "-O2 -flto -fuse-linker-plugin -Wl,--as-needed tmpdir/pr21382a.o tmpdir/pr21382.so" "" \ + {dummy.c} "pr21382.exe" "pass.out" "" "c"] \ ++ [list {pr22220a} \ ++ {-flto -fuse-linker-plugin tmpdir/pr22220main.o tmpdir/pr22220lib.so} {} \ ++ {dummy.c} {pr22220a.exe} {pass.out} {} {c++}] \ ++ [list {pr22220b} \ ++ {-flto -fuse-linker-plugin -Wl,--no-as-needed tmpdir/pr22220lib.so tmpdir/pr22220main.o} {} \ ++ {dummy.c} {pr22220b.exe} {pass.out} {} {c++}] \ + ] + + # LTO run-time tests for ELF +diff --git a/ld/testsuite/ld-plugin/pr22220.h b/ld/testsuite/ld-plugin/pr22220.h +new file mode 100644 +index 0000000000..b15b45c08d +--- /dev/null ++++ b/ld/testsuite/ld-plugin/pr22220.h +@@ -0,0 +1,8 @@ ++extern int doo(); ++ ++inline int *goo() { ++ static int xyz; ++ return &xyz; ++} ++ ++int *boo(); +diff --git a/ld/testsuite/ld-plugin/pr22220lib.cc b/ld/testsuite/ld-plugin/pr22220lib.cc +new file mode 100644 +index 0000000000..771f44f7f3 +--- /dev/null ++++ b/ld/testsuite/ld-plugin/pr22220lib.cc +@@ -0,0 +1,6 @@ ++#include "pr22220.h" ++ ++int* boo() ++{ ++ return goo (); ++} +diff --git a/ld/testsuite/ld-plugin/pr22220lib.ver b/ld/testsuite/ld-plugin/pr22220lib.ver +new file mode 100644 +index 0000000000..6da7e1a2bd +--- /dev/null ++++ b/ld/testsuite/ld-plugin/pr22220lib.ver +@@ -0,0 +1 @@ ++BAR { global: *; }; +diff --git a/ld/testsuite/ld-plugin/pr22220main.cc b/ld/testsuite/ld-plugin/pr22220main.cc +new file mode 100644 +index 0000000000..38c206f7a2 +--- /dev/null ++++ b/ld/testsuite/ld-plugin/pr22220main.cc +@@ -0,0 +1,12 @@ ++#include ++#include "pr22220.h" ++ ++int main() ++{ ++ if (boo() == goo()) ++ { ++ printf ("PASS\n"); ++ return 0; ++ } ++ return 1; ++} diff --git a/binutils.changes b/binutils.changes index 76cc4c7..e9cdb04 100644 --- a/binutils.changes +++ b/binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-aarch64-binutils.changes b/cross-aarch64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-aarch64-binutils.changes +++ b/cross-aarch64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-arm-binutils.changes b/cross-arm-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-arm-binutils.changes +++ b/cross-arm-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-avr-binutils.changes b/cross-avr-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-avr-binutils.changes +++ b/cross-avr-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-epiphany-binutils.changes b/cross-epiphany-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-epiphany-binutils.changes +++ b/cross-epiphany-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-hppa-binutils.changes b/cross-hppa-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-hppa-binutils.changes +++ b/cross-hppa-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-hppa64-binutils.changes b/cross-hppa64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-hppa64-binutils.changes +++ b/cross-hppa64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-i386-binutils.changes b/cross-i386-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-i386-binutils.changes +++ b/cross-i386-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-ia64-binutils.changes b/cross-ia64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-ia64-binutils.changes +++ b/cross-ia64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-m68k-binutils.changes b/cross-m68k-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-m68k-binutils.changes +++ b/cross-m68k-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-mips-binutils.changes b/cross-mips-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-mips-binutils.changes +++ b/cross-mips-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-ppc-binutils.changes b/cross-ppc-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-ppc-binutils.changes +++ b/cross-ppc-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-ppc64-binutils.changes b/cross-ppc64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-ppc64-binutils.changes +++ b/cross-ppc64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-ppc64le-binutils.changes b/cross-ppc64le-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-ppc64le-binutils.changes +++ b/cross-ppc64le-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-riscv64-binutils.changes b/cross-riscv64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-riscv64-binutils.changes +++ b/cross-riscv64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-rx-binutils.changes b/cross-rx-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-rx-binutils.changes +++ b/cross-rx-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-s390-binutils.changes b/cross-s390-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-s390-binutils.changes +++ b/cross-s390-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-s390x-binutils.changes b/cross-s390x-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-s390x-binutils.changes +++ b/cross-s390x-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-sparc-binutils.changes b/cross-sparc-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-sparc-binutils.changes +++ b/cross-sparc-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-sparc64-binutils.changes b/cross-sparc64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-sparc64-binutils.changes +++ b/cross-sparc64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-spu-binutils.changes b/cross-spu-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-spu-binutils.changes +++ b/cross-spu-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com diff --git a/cross-x86_64-binutils.changes b/cross-x86_64-binutils.changes index 76cc4c7..e9cdb04 100644 --- a/cross-x86_64-binutils.changes +++ b/cross-x86_64-binutils.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Sep 29 08:26:45 UTC 2017 - mliska@suse.cz + +- Update binutils-2.29-branch.diff to @a45d8fd5ffbf888 fixing PR 22220. + ------------------------------------------------------------------- Thu Sep 28 08:26:12 UTC 2017 - rguenther@suse.com