pool/cockpit-subscriptions
SHA256
19
0
Fork 2
Code Issues Pull Requests Activity

Update to v11 #11

Manually merged
abrooks merged 1 commits from :update-11 into main 2025-07-10 10:11:33 +02:00
Conversation 7 Commits 1 Files Changed 1 +1 -1
abrooks commented 2025-06-05 13:55:02 +02:00
Contributor
Copy Link
No description provided.
autogits-devel requested review from adamm 2025-06-05 13:55:12 +02:00
autogits-devel requested review from jzerebecki 2025-06-05 13:55:13 +02:00
autogits-devel requested review from malikirri 2025-06-05 13:55:13 +02:00
abrooks force-pushed update-11 from a4c83d3fb7 to fe4f254e1d 2025-06-05 13:57:50 +02:00 Compare
malikirri approved these changes 2025-06-05 14:52:01 +02:00
malikirri left a comment
First-time contributor
Copy Link

Looks good to me!

As a side note: When someone has the time and energy, update_version.sh should probably replaced with a _service file like was done in cockpit-repos (ce9fad6502)

Looks good to me! As a side note: When someone has the time and energy, `update_version.sh` should probably replaced with a _service file like was done in cockpit-repos (https://src.opensuse.org/cockpit/cockpit-repos/commit/ce9fad65021bf40a6ce7b9fec82baf009bff10a7e2fa9a99f85fe6d1cbc8c9f5)
abrooks commented 2025-06-05 15:17:14 +02:00
Author
Contributor
Copy Link

Yeah it's on my list to do at some point

Yeah it's on my list to do at some point
abrooks commented 2025-06-05 15:17:26 +02:00
Author
Contributor
Copy Link

merge ok

merge ok
adamm approved these changes 2025-06-05 15:19:30 +02:00
adamm left a comment
Contributor
Copy Link

we've had some outage for few minutes and events disappeared. let's see if this nudges it

we've had some outage for few minutes and events disappeared. let's see if this nudges it
adamm commented 2025-06-05 15:21:09 +02:00
Contributor
Copy Link

ok, need to fix something it seems .. stand by :-)

ok, need to fix something it seems .. stand by :-)
autogits-devel removed review request for jzerebecki 2025-06-05 19:10:09 +02:00
abrooks manually merged commit fe4f254e1d into main 2025-06-05 19:10:16 +02:00
adamm commented 2025-06-05 19:13:23 +02:00
Contributor
Copy Link

Fixed ... this is the case where unit tests worked, but in practice, I wasn't setting the read comments in the structure and so effectively comments were not read-in. 🎉

Fixed ... this is the case where unit tests worked, but in practice, I wasn't setting the read comments in the structure and so effectively comments were not read-in. 🎉
abrooks commented 2025-06-06 06:47:15 +02:00
Author
Contributor
Copy Link

Thanks @adamm!

Thanks @adamm!
abrooks deleted branch update-11 2025-06-06 06:47:21 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
malikirri
adamm
Labels
Clear labels
legaldb
Critical Priority
Critical legaldb priority
Archived
legaldb
High Priority
2
High legaldb priority
legaldb
Normal Priority
1
Normal legaldb priority
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super adrianSuSE autobuild-owner autobuild-review autogits_workflow_pr_bot bigironman dirkmueller eroca factory_bot gitea_test legaldb lkocman-factory maxlin_factory opensuse-review packagehub-review smithfarm
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pool/cockpit-subscriptions#11
Delete Branch ":update-11"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?