Dirk Mueller
715db45cc6
- update to 1.5.3
* Fix CVE-2019-9704 [bnc#1128937] and CVE-2019-9705 [bnc#1128935]
to avoid local DoS of the crond
* crontab: Make crontab without arguments fail
* crond: In PAM configuration include system-auth instead of
password-auth
* crond: In the systemd service file restart crond if it fails
* crond: Use the role from the crond context for system job
contexts
* Multiple small cleanups and fixes.
- refresh cronie-nheader_lines.diff and cronie-pam_config.diff
OBS-URL: https://build.opensuse.org/request/show/685771
OBS-URL: https://build.opensuse.org/package/show/Base:System/cronie?expand=0&rev=171
79 lines
2.1 KiB
Diff
79 lines
2.1 KiB
Diff
Index: src/crontab.c
|
|
===================================================================
|
|
--- src/crontab.c.orig
|
|
+++ src/crontab.c
|
|
@@ -64,7 +64,7 @@
|
|
#include "pathnames.h"
|
|
#include "structs.h"
|
|
|
|
-#define NHEADER_LINES 0
|
|
+#define NHEADER_LINES 3
|
|
|
|
enum opt_t {opt_unknown, opt_list, opt_delete, opt_edit, opt_replace, opt_hostset, opt_hostget};
|
|
|
|
@@ -485,7 +485,7 @@ static void edit_cmd(void) {
|
|
char n[MAX_FNAME], q[MAX_TEMPSTR];
|
|
const char *editor;
|
|
FILE *f;
|
|
- int ch = '\0', t;
|
|
+ int ch = '\0', t, x;
|
|
struct stat statbuf;
|
|
struct utimbuf utimebuf;
|
|
WAIT_T waiter;
|
|
@@ -537,13 +537,25 @@ static void edit_cmd(void) {
|
|
}
|
|
|
|
Set_LineNum(1)
|
|
- /*
|
|
- * NHEADER_LINES processing removed for clarity
|
|
- * (NHEADER_LINES == 0 in all Red Hat crontabs)
|
|
- */
|
|
- /* copy the rest of the crontab (if any) to the temp file.
|
|
- */
|
|
- if (EOF != ch)
|
|
+
|
|
+ /* ignore the top few comments since we probably put them there.
|
|
+ */
|
|
+ x = 0;
|
|
+ while (EOF != (ch = get_char(f))) {
|
|
+ if ('#' != ch) {
|
|
+ putc(ch, NewCrontab);
|
|
+ break;
|
|
+ }
|
|
+ while (EOF != (ch = get_char(f)))
|
|
+ if (ch == '\n')
|
|
+ break;
|
|
+ if (++x >= NHEADER_LINES)
|
|
+ break;
|
|
+ }
|
|
+
|
|
+ /* copy the rest of the crontab (if any) to the temp file.
|
|
+ */
|
|
+ if (EOF != ch)
|
|
while (EOF != (ch = get_char(f)))
|
|
putc(ch, NewCrontab);
|
|
|
|
@@ -751,6 +763,7 @@ static int replace_cmd(void) {
|
|
int error = 0;
|
|
entry *e;
|
|
uid_t file_owner;
|
|
+ time_t now = time(NULL);
|
|
char **envp;
|
|
char *safename;
|
|
int envs = 0, entries = 0;
|
|
@@ -781,10 +794,10 @@ static int replace_cmd(void) {
|
|
*
|
|
* VERY IMPORTANT: make sure NHEADER_LINES agrees with this code.
|
|
*/
|
|
- /*fprintf(tmp, "# DO NOT EDIT THIS FILE - edit the master and reinstall.\n");
|
|
- *fprintf(tmp, "# (%s installed on %-24.24s)\n", Filename, ctime(&now));
|
|
- *fprintf(tmp, "# (Cron version %s)\n", CRON_VERSION);
|
|
- */
|
|
+ fprintf(tmp, "# DO NOT EDIT THIS FILE - edit the master and reinstall.\n");
|
|
+ fprintf(tmp, "# (%s installed on %-24.24s)\n", Filename, ctime(&now));
|
|
+ fprintf(tmp, "# (Cronie version %s)\n", CRON_VERSION);
|
|
+
|
|
#ifdef WITH_SELINUX
|
|
if (selinux_context)
|
|
fprintf(tmp, "SELINUX_ROLE_TYPE=%s\n", selinux_context);
|