diff --git a/dbus-1-glib.changes b/dbus-1-glib.changes index e2fc0cd..d93a21c 100644 --- a/dbus-1-glib.changes +++ b/dbus-1-glib.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Mon May 26 11:11:38 CEST 2008 - tambet@suse.de + +- Don't assert on unknown property access (bfo #16079). Without this patch, + any user can kill NetworkManager for example (bgo #534544). + ------------------------------------------------------------------- Tue May 13 21:54:50 CEST 2008 - aj@suse.de diff --git a/dbus-1-glib.spec b/dbus-1-glib.spec index 834fe48..6721bef 100644 --- a/dbus-1-glib.spec +++ b/dbus-1-glib.spec @@ -17,7 +17,7 @@ Url: http://dbus.freedesktop.org/ License: GPL v2 or later; Other uncritical OpenSource License Group: Development/Libraries/Other Version: 0.74 -Release: 81 +Release: 83 AutoReqProv: on Summary: GLib-based library for using D-Bus Source0: dbus-glib-%{version}.tar.gz @@ -26,6 +26,7 @@ Patch1: dbus-glib-gvalue-utils-fix-thoenig-01.patch Patch2: dbus-glib-introspection-xml.patch Patch3: dbus-glib-proxy-signals-once.patch Patch4: dbus-glib-ignore-namespaces.patch +Patch5: dbus-glib-unknown-properties.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build Requires: dbus-1 >= %( echo `rpm -q --queryformat '%{VERSION}-%{RELEASE}' dbus-1`) @@ -124,6 +125,7 @@ Authors: %patch2 -p1 %patch3 -p1 %patch4 -p1 +%patch5 -p1 %build autoreconf -fi @@ -169,6 +171,9 @@ make DESTDIR=%{buildroot} install %{_datadir}/gtk-doc/html/dbus-glib/* %changelog +* Mon May 26 2008 tambet@suse.de +- Don't assert on unknown property access (bfo #16079). Without this patch, + any user can kill NetworkManager for example (bgo #534544). * Tue May 13 2008 aj@suse.de - Reduce BuildRequires. * Thu Apr 10 2008 ro@suse.de diff --git a/dbus-glib-unknown-properties.patch b/dbus-glib-unknown-properties.patch new file mode 100644 index 0000000..1cef19f --- /dev/null +++ b/dbus-glib-unknown-properties.patch @@ -0,0 +1,17 @@ +Index: dbus-glib-0.74/dbus/dbus-gobject.c +=================================================================== +--- dbus-glib-0.74.orig/dbus/dbus-gobject.c ++++ dbus-glib-0.74/dbus/dbus-gobject.c +@@ -1531,6 +1531,12 @@ export_signals (DBusGConnection *connect + dbus_g_signal_closure_finalize); + g_free (s); + } ++ else ++ { ++ ret = dbus_message_new_error_printf (message, ++ DBUS_ERROR_INVALID_ARGS, ++ "No such property %s", wincaps_propname); ++ } + } + } +