diff --git a/dnsmasq.changes b/dnsmasq.changes index 0100e92..0e19708 100644 --- a/dnsmasq.changes +++ b/dnsmasq.changes @@ -1,3 +1,15 @@ +------------------------------------------------------------------- +Fri Feb 22 07:10:51 UTC 2019 - Franck Bui + +- Drop use of $FIRST_ARG in .spec + + The use of $FIRST_ARG was probably required because of the + %service_* rpm macros were playing tricks with the shell positional + parameters. This is bad practice and error prones so let's assume + that no macros should do that anymore and hence it's safe to assume + that positional parameters remains unchanged after any rpm macro + call. + ------------------------------------------------------------------- Wed Jan 23 23:03:22 UTC 2019 - Cristian Rodríguez diff --git a/dnsmasq.spec b/dnsmasq.spec index 17d8299..1e2c952 100644 --- a/dnsmasq.spec +++ b/dnsmasq.spec @@ -136,7 +136,7 @@ fi %postun %service_del_postun %{name}.service # reload dbus after uninstall, our policies are gone again -if [ ${FIRST_ARG:-$1} -eq 0 -a -z "${TRANSACTIONAL_UPDATE}" \ +if [ $1 -eq 0 -a -z "${TRANSACTIONAL_UPDATE}" \ -a -x /usr/bin/systemctl ]; then /usr/bin/systemctl reload dbus.service 2>/dev/null || : fi