42 lines
1.4 KiB
Diff
42 lines
1.4 KiB
Diff
|
From b3cadb2825422e37c35fdc78ea9497e4bdc95990 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Aaron Conole <aconole@redhat.com>
|
||
|
|
Date: Tue, 22 Mar 2016 17:37:14 -0400
|
||
|
|
Subject: [PATCH] e1000: fix missing link interrupt check brackets
|
||
|
|
|
||
|
|
The device lsc interrupt check has a misleading whitespace around it which
|
||
|
|
can be improved by adding appropriate braces to the check. Since the ret
|
||
|
|
variable was checked after previous assignment, this introduces no functional
|
||
|
|
change.
|
||
|
|
|
||
|
|
Fixes: 921a72008f76 ("e1000: add Rx interrupt handler")
|
||
|
|
|
||
|
|
Signed-off-by: Aaron Conole <aconole@redhat.com>
|
||
|
|
Acked-by: Panu Matilainen <pmatilai@redhat.com>
|
||
|
|
---
|
||
|
|
drivers/net/e1000/em_ethdev.c | 3 ++-
|
||
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
|
||
|
|
index 1f0a7f4..9b5e1af 100644
|
||
|
|
--- a/drivers/net/e1000/em_ethdev.c
|
||
|
|
+++ b/drivers/net/e1000/em_ethdev.c
|
||
|
|
@@ -666,13 +666,14 @@ eth_em_start(struct rte_eth_dev *dev)
|
||
|
|
|
||
|
|
if (rte_intr_allow_others(intr_handle)) {
|
||
|
|
/* check if lsc interrupt is enabled */
|
||
|
|
- if (dev->data->dev_conf.intr_conf.lsc != 0)
|
||
|
|
+ if (dev->data->dev_conf.intr_conf.lsc != 0) {
|
||
|
|
ret = eth_em_interrupt_setup(dev);
|
||
|
|
if (ret) {
|
||
|
|
PMD_INIT_LOG(ERR, "Unable to setup interrupts");
|
||
|
|
em_dev_clear_queues(dev);
|
||
|
|
return ret;
|
||
|
|
}
|
||
|
|
+ }
|
||
|
|
} else {
|
||
|
|
rte_intr_callback_unregister(intr_handle,
|
||
|
|
eth_em_interrupt_handler,
|
||
|
|
--
|
||
|
|
2.8.4
|
||
|
|
|