pool/dracut
SHA256
4
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accepting request 678954 from Base:System

Browse Source 
- purge-kernels: Avoid endless loop when uninstalling kernels that depend on
  KMPs which in themselves depend on other packages (bsc#1125327) (forwarded request 678943 from dmolkentin)

OBS-URL: https://build.opensuse.org/request/show/678954
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/dracut?expand=0&rev=134
This commit is contained in:
Dominique Leuenberger 2019-03-05 11:15:09 +00:00 committed by Git OBS Bridge
commit ca9452dc20
2 changed files with 48 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dracut.changes
View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Feb 25 14:51:07 UTC 2019 - Daniel Molkentin <daniel.molkentin@suse.com>
- purge-kernels: Avoid endless loop when uninstalling kernels that depend on
KMPs which in themselves depend on other packages (bsc#1125327)
------------------------------------------------------------------- -------------------------------------------------------------------
Fri Feb 15 17:23:11 UTC 2019 - Daniel Molkentin <daniel.molkentin@suse.com> Fri Feb 15 17:23:11 UTC 2019 - Daniel Molkentin <daniel.molkentin@suse.com>

46
purge-kernels
View File

@ -268,8 +268,37 @@ sub list_old_packages {
return @packages; return @packages;
} }
sub find_package {
my $name = shift @_;
my $version = shift @_;
my @packages = @_;
my $expr = "^" . quotemeta("$name-$version");
my @found = grep { $_ =~ $expr } @packages;
return @found if @found;
$expr = "^" . quotemeta($name) . " = " . quotemeta($version) . "\$";
@found = grep {
my @provides = qx/rpm -q --provides $_/;
chomp (@provides);
grep { $_ =~ $expr} @provides;
} @packages;
return @found;
}
# Try to remove a list of packages.
#
# If there is a KMP or livepatch depending on the package remove it as well. If
# there is another package depending on the kernel keep the kernel. If there is
# a package that depends on a KMP keep the KMP and a kernel required to use the
# KMP.
# In each step a KMP or livepatch may be added or a package which cannot be
# removed due to dependencies is marked as taboo and removed from the list.
#
# Finish when packages uninstall successfully or we can't find any packages to
# add or remove from the list to make it uninstallable.
sub remove_packages { sub remove_packages {
my @packages = @_; my @packages = @_;
my %taboo_packages;
while (1) { while (1) {
pipe(my $read, my $write); pipe(my $read, my $write);
@ -296,25 +325,30 @@ sub remove_packages {
print "Removed:\n ", join("\n ", @packages), "\n"; print "Removed:\n ", join("\n ", @packages), "\n";
return 1; return 1;
} }
my ($retry, @problems); my $retry = 0;
my %old_packages = map { $_ => 1 } @packages; my %old_packages = map { $_ => 1 } @packages;
my %new_packages; my %new_packages;
for (@out) { for (@out) {
if (/ is needed by \(installed\) (kernel-syms-.*|kgraft-patch-.*|kernel-livepatch-.*|.*-kmp-.*)/ && if (/ is needed by \(installed\) (kernel-syms-.*|kgraft-patch-.*|kernel-livepatch-.*|.*-kmp-.*)/ &&
!$old_packages{$1}) { !$old_packages{$1} && !$taboo_packages{$1}) {
push(@packages, $1) unless $new_packages{$1}; push(@packages, $1) unless $new_packages{$1};
$new_packages{$1} = 1; $new_packages{$1} = 1;
$retry = 1; $retry = 1;
} elsif (/([^ \t]*) = ([^ \t]*) is needed by \(installed\) /) { } elsif (/([^ \t]*) = ([^ \t]*) is needed by \(installed\) /) {
my @unremovable = find_package($1, $2, @packages);
my $match = $unremovable[$#unremovable];
if ($match) {
print STDERR "$0: $_\n"; print STDERR "$0: $_\n";
@packages = grep ! /$1-$2/, @packages; print STDERR "$0: Keeping $1 = $2 ($match)\n";
@packages = grep { $_ !~ $match } @packages;
$taboo_packages{$match} = 1;
$retry = 1; $retry = 1;
} else { last; # Only remove one package providing the dependency from the list
push(@problems, $_); }
} }
} }
if (!$retry) { if (!$retry) {
print STDERR join("\n", @problems), "\n"; print STDERR join("\n", @out), "\n";
print STDERR "$0: giving up.\n"; print STDERR "$0: giving up.\n";
return 0; return 0;
} }