pool/drbd
SHA256
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accepting request 757251 from network:ha-clustering:Unstable

Browse Source 
bsc#1158446, fix metadata limit due to 64k page size of ppc64le.

OBS-URL: https://build.opensuse.org/request/show/757251
OBS-URL: https://build.opensuse.org/package/show/network:ha-clustering:Factory/drbd?expand=0&rev=99
This commit is contained in:
nick wang 2019-12-16 06:39:41 +00:00 committed by Git OBS Bridge
parent 0498b863bb
commit a2b450528a
3 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
drbd-fix-zero-metadata-limit-by-page-size-misaligned.patch Normal file
View File

@ -0,0 +1,41 @@
From 55293e6d7064c39183c3622c63ef6c2ab7162b80 Mon Sep 17 00:00:00 2001
From: Nick Wang <nwang@suse.com>
Date: Wed, 11 Dec 2019 14:50:21 +0800
Subject: [PATCH] drbd: fix zero metadata limit by misaligned with page size
Metadata is aligned on 4k blocks, which is ok for x86 platform.
But may cause a result of zero page with PPC64LE or ARM with
64k page size.
And calculate effective bytes directly from sector size.
Error log:
...
drbd0: Device size clipped from 2097016s to 0s due to metadata size
...
Signed-off-by: Nick Wang <nwang@suse.com>
CC: drbd-dev@lists.linbit.com
---
drbd/drbd_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drbd/drbd_main.c b/drbd/drbd_main.c
index a7294639..336a4177 100644
--- a/drbd/drbd_main.c
+++ b/drbd/drbd_main.c
@@ -5589,8 +5589,7 @@ u64 directly_connected_nodes(struct drbd_resource *resource, enum which_state wh
static sector_t bm_sect_to_max_capacity(unsigned int bm_max_peers, sector_t bm_sect)
{
- u64 bm_pages = bm_sect >> (PAGE_SHIFT - SECTOR_SHIFT);
- u64 bm_bytes = bm_pages << PAGE_SHIFT;
+ u64 bm_bytes = bm_sect << SECTOR_SHIFT;
u64 bm_bytes_per_peer = div_u64(bm_bytes, bm_max_peers);
u64 bm_bits_per_peer = bm_bytes_per_peer * BITS_PER_BYTE;
return BM_BIT_TO_SECT(bm_bits_per_peer);
--
2.16.4

6
drbd.changes
View File

@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Dec 16 06:29:42 UTC 2019 - nick wang <nwang@suse.com>
- bsc#1158446, fix metadata limit due to 64k page size of ppc64le.
add patch drbd-fix-zero-metadata-limit-by-page-size-misaligned.patch
-------------------------------------------------------------------
Thu Oct 17 17:48:47 UTC 2019 - Richard Brown <rbrown@suse.com>

4
drbd.spec
View File

@ -35,7 +35,8 @@ Source2: Module.supported
Source3: drbd_git_revision
Patch1: fix-resync-finished-with-syncs-have-bits-set.patch
Patch2: rely-on-sb-handlers.patch
Patch3: suse-coccinelle.patch
Patch3: drbd-fix-zero-metadata-limit-by-page-size-misaligned.patch
Patch4: suse-coccinelle.patch
#https://github.com/openSUSE/rpmlint-checks/blob/master/KMPPolicyCheck.py
BuildRequires: coccinelle
BuildRequires: kernel-source
@ -71,6 +72,7 @@ installed kernel.
%patch1 -p1
%patch2 -p1
%patch3 -p1
%patch4 -p1
mkdir source
cp -a drbd/. source/. || :