From 8ae0cb982e1a8b4a76c37fa038057f0ab887836874763efbf658f89d3ec4e1fe Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger Date: Fri, 30 Apr 2021 09:38:11 +0000 Subject: [PATCH] Accepting request 889500 from home:dimstar:Factory - Add c95a70bfeae25b.patch: Fix build with cmake 3.20.1. OBS-URL: https://build.opensuse.org/request/show/889500 OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/evolution-data-server?expand=0&rev=393 --- c95a70bfeae25b.patch | 75 +++++++++++++++++++++++++++++++++++ evolution-data-server.changes | 5 +++ evolution-data-server.spec | 2 + 3 files changed, 82 insertions(+) create mode 100644 c95a70bfeae25b.patch diff --git a/c95a70bfeae25b.patch b/c95a70bfeae25b.patch new file mode 100644 index 0000000..226a034 --- /dev/null +++ b/c95a70bfeae25b.patch @@ -0,0 +1,75 @@ +From c95a70bfeae25ba11fbe50fe759a6cdb29388e44 Mon Sep 17 00:00:00 2001 +From: Milan Crha +Date: Wed, 14 Apr 2021 16:58:08 +0200 +Subject: [PATCH] PrintableOptions.cmake: Correct variable name comparison + +CMake 3.20.1 errors out with: + +CMake Error at cmake/modules/PrintableOptions.cmake:38 (message): + variable name cannot be empty + Call Stack (most recent call first): + CMakeLists.txt:152 (add_printable_variable) + +Change how the parameter value is compared, to fix it. +--- + cmake/modules/PrintableOptions.cmake | 20 ++++++++++---------- + 1 file changed, 10 insertions(+), 10 deletions(-) + +diff --git a/cmake/modules/PrintableOptions.cmake b/cmake/modules/PrintableOptions.cmake +index ba1c9d0b7..339f1da4b 100644 +--- a/cmake/modules/PrintableOptions.cmake ++++ b/cmake/modules/PrintableOptions.cmake +@@ -19,40 +19,40 @@ + # prints all the build options previously added with the above functions + + macro(add_printable_variable_bare _name) +- if(_name STREQUAL "") ++ if("${_name}" STREQUAL "") + message(FATAL_ERROR "variable name cannot be empty") +- endif(_name STREQUAL "") ++ endif("${_name}" STREQUAL "") + list(APPEND _printable_options ${_name}) + endmacro() + + macro(add_printable_option _name _description _default_value) +- if(_name STREQUAL "") ++ if("${_name}" STREQUAL "") + message(FATAL_ERROR "option name cannot be empty") +- endif(_name STREQUAL "") ++ endif("${_name}" STREQUAL "") + option(${_name} ${_description} ${_default_value}) + add_printable_variable_bare(${_name}) + endmacro() + + macro(add_printable_variable _name _description _default_value) +- if(_name STREQUAL "") ++ if("${_name}" STREQUAL "") + message(FATAL_ERROR "variable name cannot be empty") +- endif(_name STREQUAL "") ++ endif("${_name}" STREQUAL "") + set(${_name} ${_default_value} CACHE STRING ${_description}) + add_printable_variable_bare(${_name}) + endmacro() + + macro(add_printable_variable_path _name _description _default_value) +- if(_name STREQUAL "") ++ if("${_name}" STREQUAL "") + message(FATAL_ERROR "path variable name cannot be empty") +- endif(_name STREQUAL "") ++ endif("${_name}" STREQUAL "") + set(${_name} ${_default_value} CACHE PATH ${_description}) + add_printable_variable_bare(${_name}) + endmacro() + + macro(add_printable_variable_filepath _name _description _default_value) +- if(_name STREQUAL "") ++ if("${_name}" STREQUAL "") + message(FATAL_ERROR "filepath variable name cannot be empty") +- endif(_name STREQUAL "") ++ endif("${_name}" STREQUAL "") + set(${_name} ${_default_value} CACHE FILEPATH ${_description}) + add_printable_variable_bare(${_name}) + endmacro() +-- +GitLab + diff --git a/evolution-data-server.changes b/evolution-data-server.changes index 577063a..484de71 100644 --- a/evolution-data-server.changes +++ b/evolution-data-server.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Fri Apr 30 07:41:51 UTC 2021 - Dominique Leuenberger + +- Add c95a70bfeae25b.patch: Fix build with cmake 3.20.1. + ------------------------------------------------------------------- Sat Mar 20 08:25:38 UTC 2021 - Michael Gorse diff --git a/evolution-data-server.spec b/evolution-data-server.spec index 0e5a156..fc53cfb 100644 --- a/evolution-data-server.spec +++ b/evolution-data-server.spec @@ -40,6 +40,8 @@ Group: Development/Libraries/GNOME URL: https://wiki.gnome.org/Apps/Evolution Source0: https://download.gnome.org/sources/evolution-data-server/3.40/%{name}-%{version}.tar.xz Source99: baselibs.conf +# PATCH-FIX-UPSTREAM c95a70bfeae25b.patch dimstar@opensuse.org -- Fix build with cmake 3.20.1 +Patch0: https://gitlab.gnome.org/GNOME/evolution-data-server/-/commit/c95a70bfeae25b.patch BuildRequires: cmake BuildRequires: db-devel