From 6dd9e0b287e864f1928cf9747dfb56a036aab1d6b9f59a13f8949bb585093414 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Wed, 4 Oct 2023 11:21:39 +0000 Subject: [PATCH 1/2] Accepting request 1115535 from home:manfred-h - Add ffmpeg-x86-mathops.patch to allow building for Leap OBS-URL: https://build.opensuse.org/request/show/1115535 OBS-URL: https://build.opensuse.org/package/show/multimedia:libs/ffmpeg-6?expand=0&rev=11 --- ffmpeg-6.changes | 5 ++++ ffmpeg-6.spec | 3 ++ ffmpeg-x86-mathops.patch | 59 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+) create mode 100644 ffmpeg-x86-mathops.patch diff --git a/ffmpeg-6.changes b/ffmpeg-6.changes index 7d24e89..f6323c6 100644 --- a/ffmpeg-6.changes +++ b/ffmpeg-6.changes @@ -1,3 +1,8 @@ +------------------------------------------------------------------- +Wed Oct 4 07:59:01 UTC 2023 - Manfred Hollstein + +- Add ffmpeg-x86-mathops.patch to allow building for Leap + ------------------------------------------------------------------- Mon Jul 31 09:05:39 UTC 2023 - llyyr diff --git a/ffmpeg-6.spec b/ffmpeg-6.spec index 248f4a7..3b5d2df 100644 --- a/ffmpeg-6.spec +++ b/ffmpeg-6.spec @@ -107,6 +107,7 @@ Patch5: work-around-abi-break.patch Patch6: 0001-avfilter-vf_libplacebo-remove-deprecated-field.diff Patch10: ffmpeg-chromium.patch Patch91: ffmpeg-dlopen-openh264.patch +Patch92: ffmpeg-x86-mathops.patch %if %{with amf_sdk} BuildRequires: AMF-devel @@ -537,6 +538,7 @@ break compatibility without any notice. %patch5 -p1 %patch10 -p1 %patch91 -p1 +%patch92 -p1 # Remove when packaging ffmpeg 6.1 if pkg-config --atleast-version 6 libplacebo; then %patch6 -p1 @@ -855,6 +857,7 @@ Patch4: ffmpeg-4.2-dlopen-fdk_aac.patch Patch5: work-around-abi-break.patch Patch10: ffmpeg-chromium.patch Patch91: ffmpeg-dlopen-openh264.patch +Patch92: ffmpeg-x86-mathops.patch BuildRequires: c_compiler Requires: this-is-only-for-build-envs diff --git a/ffmpeg-x86-mathops.patch b/ffmpeg-x86-mathops.patch new file mode 100644 index 0000000..ada8b7b --- /dev/null +++ b/ffmpeg-x86-mathops.patch @@ -0,0 +1,59 @@ +diff -rup a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h +--- a/libavcodec/x86/mathops.h 2023-10-01 13:02:26.829463017 +0200 ++++ b/libavcodec/x86/mathops.h 2023-10-01 13:05:19.219502582 +0200 +@@ -35,12 +35,20 @@ + static av_always_inline av_const int MULL(int a, int b, unsigned shift) + { + int rt, dummy; ++ if (__builtin_constant_p(shift)) + __asm__ ( + "imull %3 \n\t" + "shrdl %4, %%edx, %%eax \n\t" + :"=a"(rt), "=d"(dummy) +- :"a"(a), "rm"(b), "ci"((uint8_t)shift) ++ :"a"(a), "rm"(b), "i"(shift & 0x1F) + ); ++ else ++ __asm__ ( ++ "imull %3 \n\t" ++ "shrdl %4, %%edx, %%eax \n\t" ++ :"=a"(rt), "=d"(dummy) ++ :"a"(a), "rm"(b), "c"((uint8_t)shift) ++ ); + return rt; + } + +@@ -113,19 +121,31 @@ __asm__ volatile(\ + // avoid +32 for shift optimization (gcc should do that ...) + #define NEG_SSR32 NEG_SSR32 + static inline int32_t NEG_SSR32( int32_t a, int8_t s){ ++ if (__builtin_constant_p(s)) + __asm__ ("sarl %1, %0\n\t" + : "+r" (a) +- : "ic" ((uint8_t)(-s)) ++ : "i" (-s & 0x1F) + ); ++ else ++ __asm__ ("sarl %1, %0\n\t" ++ : "+r" (a) ++ : "c" ((uint8_t)(-s)) ++ ); + return a; + } + + #define NEG_USR32 NEG_USR32 + static inline uint32_t NEG_USR32(uint32_t a, int8_t s){ ++ if (__builtin_constant_p(s)) + __asm__ ("shrl %1, %0\n\t" + : "+r" (a) +- : "ic" ((uint8_t)(-s)) ++ : "i" (-s & 0x1F) + ); ++ else ++ __asm__ ("shrl %1, %0\n\t" ++ : "+r" (a) ++ : "c" ((uint8_t)(-s)) ++ ); + return a; + } + From d99756547d57834f2b3395c1f5dba5cfdf5d1462cb8743443a3e1f4c7d9f9aef Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Wed, 4 Oct 2023 11:42:00 +0000 Subject: [PATCH 2/2] use git-format-patch to extract the patch from git OBS-URL: https://build.opensuse.org/package/show/multimedia:libs/ffmpeg-6?expand=0&rev=12 --- ...ops-clip-constants-used-with-shift-i.patch | 23 ++++++++++++++++--- ffmpeg-6.changes | 3 ++- ffmpeg-6.spec | 7 ++++-- 3 files changed, 27 insertions(+), 6 deletions(-) rename ffmpeg-x86-mathops.patch => 0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch (69%) diff --git a/ffmpeg-x86-mathops.patch b/0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch similarity index 69% rename from ffmpeg-x86-mathops.patch rename to 0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch index ada8b7b..511e302 100644 --- a/ffmpeg-x86-mathops.patch +++ b/0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch @@ -1,6 +1,20 @@ -diff -rup a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h ---- a/libavcodec/x86/mathops.h 2023-10-01 13:02:26.829463017 +0200 -+++ b/libavcodec/x86/mathops.h 2023-10-01 13:05:19.219502582 +0200 +From effadce6c756247ea8bae32dc13bb3e6f464f0eb Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?R=C3=A9mi=20Denis-Courmont?= +Date: Sun, 16 Jul 2023 18:18:02 +0300 +Subject: [PATCH] avcodec/x86/mathops: clip constants used with shift + instructions within inline assembly + +Fixes assembling with binutil as >= 2.41 + +Signed-off-by: James Almer +--- + libavcodec/x86/mathops.h | 26 +++++++++++++++++++++++--- + 1 file changed, 23 insertions(+), 3 deletions(-) + +diff --git a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h +index 6298f5ed19..ca7e2dffc1 100644 +--- a/libavcodec/x86/mathops.h ++++ b/libavcodec/x86/mathops.h @@ -35,12 +35,20 @@ static av_always_inline av_const int MULL(int a, int b, unsigned shift) { @@ -57,3 +71,6 @@ diff -rup a/libavcodec/x86/mathops.h b/libavcodec/x86/mathops.h return a; } +-- +2.42.0 + diff --git a/ffmpeg-6.changes b/ffmpeg-6.changes index f6323c6..43fcdf4 100644 --- a/ffmpeg-6.changes +++ b/ffmpeg-6.changes @@ -1,7 +1,8 @@ ------------------------------------------------------------------- Wed Oct 4 07:59:01 UTC 2023 - Manfred Hollstein -- Add ffmpeg-x86-mathops.patch to allow building for Leap +- Add 0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch + to resolve a build failure on 15.4/15.5. ------------------------------------------------------------------- Mon Jul 31 09:05:39 UTC 2023 - llyyr diff --git a/ffmpeg-6.spec b/ffmpeg-6.spec index 3b5d2df..bf6b1cc 100644 --- a/ffmpeg-6.spec +++ b/ffmpeg-6.spec @@ -17,6 +17,9 @@ %define flavor @BUILD_FLAVOR@%{nil} +# +# preamble is present twice, watch out +# %if "%{flavor}" != "ffmpeg-6-mini" # Create proper conflicts to make sure we require all from one version @@ -107,7 +110,7 @@ Patch5: work-around-abi-break.patch Patch6: 0001-avfilter-vf_libplacebo-remove-deprecated-field.diff Patch10: ffmpeg-chromium.patch Patch91: ffmpeg-dlopen-openh264.patch -Patch92: ffmpeg-x86-mathops.patch +Patch92: 0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch %if %{with amf_sdk} BuildRequires: AMF-devel @@ -857,7 +860,7 @@ Patch4: ffmpeg-4.2-dlopen-fdk_aac.patch Patch5: work-around-abi-break.patch Patch10: ffmpeg-chromium.patch Patch91: ffmpeg-dlopen-openh264.patch -Patch92: ffmpeg-x86-mathops.patch +Patch92: 0001-avcodec-x86-mathops-clip-constants-used-with-shift-i.patch BuildRequires: c_compiler Requires: this-is-only-for-build-envs