Accepting request 1086606 from home:chrBrd:branches:hardware

Improve comments and make minor tidies.

OBS-URL: https://build.opensuse.org/request/show/1086606
OBS-URL: https://build.opensuse.org/package/show/hardware/gasket-driver?expand=0&rev=2

_service

@@ -1,17 +1,27 @@
-<!-- For the closest thing to official documentation see:
+<!--
-https://github.com/openSUSE/obs-service-tar_scm#user-documentation -->
+For documentation on the contents of this file see:
+https://github.com/openSUSE/obs-service-tar_scm#user-documentation
+https://openbuildservice.org/help/manuals/obs-user-guide/cha.obs.source_service.html
+https://openbuildservice.org/help/manuals/obs-user-guide/cha.obs.best-practices.scm_integration.html
+https://en.opensuse.org/openSUSE:Build_Service_Concept_SourceService
+-->
 <services>
+  <!-- Download the module source from GitHub. -->
   <service name="obs_scm">
     <param name="url">https://github.com/google/gasket-driver</param>
+    <param name="scm">git</param>
+    <param name="exclude">.git</param>
     <param name="revision">97aeba5</param>
     <param name="versionformat">%h</param>
-    <param name="scm">git</param>
   </service>
-  <service name="set_version" mode="buildtime"/>
+  <!-- Compress source files into a tarball. -->
   <service name="tar" mode="buildtime"/>
   <service name="recompress" mode="buildtime">
     <param name="file">*.tar</param>
     <param name="compression">xz</param>
   </service>
+  <!--  This has to be included or the build will fail attempting to parse the "Version"
+        line in the spec file.  -->
+  <service name="set_version" mode="buildtime"/>
 </services>
 

gasket-driver.changes

@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Thu May 11 18:50:01 UTC 2023 - Chris Bradbury <obs@chrbrd.com>
+
+Improve comments and make minor tidies. 
+
 -------------------------------------------------------------------
 Thu May 11 11:51:32 UTC 2023 - Chris Bradbury <obs@chrbrd.com>
 

gasket-driver.spec

@@ -14,55 +14,48 @@
 #
 # Please submit bugfixes or comments via https://bugs.opensuse.org/
 
-#
+#===
 # Packaging Notes:
-# ----
 #
 # For information on building KMPs see:
 # https://documentation.suse.com/sbp/all/single-html/SBP-KMP-Manual-SLE12SP2
 # https://en.opensuse.org/Kernel_Module_Packages
 #
-# For information on `sysusers` stuff used to create the `apex` group see:
+# For information on `sysusers` macros used to create the `apex` group see:
 # https://en.opensuse.org/openSUSE:Packaging_guidelines#Users_and_Groups
-#
+#---
-# Examples:
+
-# https://pmbs.links2linux.org/package/view_file/Essentials/r8168/r8168.spec
+# The following directive ensures the package will build correctly on OBS if it
-# https://build.opensuse.org/package/view_file/openSUSE:Factory/vhba-kmp/vhba-kmp.spec
+# builds locally without problems. See:
-# https://build.opensuse.org/package/show/home:jeff_mahoney:coral-ai/gasket-driver
-# https://build.opensuse.org/package/view_file/home:Sauerland/rtl8812AU_8821AU/   <- for signing?
-#
-# ===
-# The following 'comment' ensures the package will build correctly on OBS. See:
 # https://en.opensuse.org/openSUSE:Build_Service_Tips_and_Tricks#Permission_denied_errors
 #
 # norootforbuild
-#
 
-Name:		gasket-driver
+Name:           gasket-driver
-Version:	97aeba5	
+Version:        97aeba5
-Release:	0
+Release:        0
-Summary:	The Coral Gasket Driver allows usage of the Coral EdgeTPU on Linux systems
+Summary:        The Coral Gasket Driver allows usage of the Coral EdgeTPU on Linux systems
-License:	GPL-2.0-only
+License:        GPL-2.0-only
-Group:		System/Kernel
+Group:          System/Kernel
-URL:		https://github.com/google/gasket-driver
+URL:            https://github.com/google/gasket-driver
-Source0:	%{name}-%{version}.tar.xz 
+Source0:        %{name}-%{version}.tar.xz 
-Source1:	group.conf
+Source1:        group.conf
-Source2: 	preamble
+Source2:        preamble
-BuildRequires:	%kernel_module_package_buildreqs
+BuildRequires:  %kernel_module_package_buildreqs
-BuildRequires:	sysuser-tools
+BuildRequires:  sysuser-tools
-BuildRequires:	pesign-obs-integration
+BuildRequires:  pesign-obs-integration
-Requires:	%{name}-kmp
+Requires:       %{name}-kmp
 %sysusers_requires
 
-# The following 'comment' instructs the build service to temporarily save
+# This directive instructs the build service to temporarily save the project's
-# the project's certificate as %%_sourcedir/_projectcert.crt. See:
+# certificate as %%_sourcedir/_projectcert.crt. See:
 # https://github.com/openSUSE/pesign-obs-integration
 # https://documentation.suse.com/sbp/all/html/SBP-KMP-Manual/index.html#sec-signing-module-object
 # https://documentation.suse.com/sbp/all/html/SBP-KMP-Manual/index.html#sec-appendix-a1
 #
 # needssslcertforbuild
 #
-# Having included the above 'comment', using the `-c` flag below will cause
+# Having included the above directive, using the `-c` flag below will cause
 # the "ueficert" package to get built. `%%_sourcedir` must be prefixed as the
 # working dir is changed before the build service attempts to source the certificate.
 %kernel_module_package -p preamble -c %_sourcedir/_projectcert.crt
@@ -84,7 +77,6 @@ Group:          System/Kernel
 The Linux Kernel Module Package for the Coral Gasket Driver.
 
 %prep
-ls -al  %_sourcedir
 %setup -q
 mkdir -p obj