From fb3f526245ae21c79428dc1624e03485b6bc4db4fc97824aa7c465f9adfe2d7b Mon Sep 17 00:00:00 2001
From: Tom de Vries <tdevries@suse.com>
Date: Thu, 18 Nov 2021 17:38:55 +0000
Subject: [PATCH] - Maintenance script qa.sh:   - Add KFAIL. - Patches updated
 (increase sleep time):   *
 gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch - Patches
 added (debug hard to reproduce failure):   *
 gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch

OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=305
---
 ...estsuite-debug-gdb.arch-i386-sse.exp.patch | 47 +++++++++++++++++++
 ...-in-gdb.threads-detach-step-over.exp.patch |  2 +-
 gdb.changes                                   | 10 ++++
 gdb.spec                                      |  4 ++
 qa.sh                                         |  1 +
 5 files changed, 63 insertions(+), 1 deletion(-)
 create mode 100644 gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch

diff --git a/gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch b/gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch
new file mode 100644
index 0000000..a9262c9
--- /dev/null
+++ b/gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch
@@ -0,0 +1,47 @@
+[gdb/testsuite] Debug gdb.arch/i386-sse.exp
+
+There's a failure filed at PR28504 - "FAIL: gdb.arch/i386-sse.exp: check
+contents of data[2]" that sofar hasn't been reproduced outside OBS.
+
+This patch adds printing of more info to help make sense of it.
+
+---
+ gdb/testsuite/gdb.arch/i386-sse.exp | 11 +++++++++++
+ 1 file changed, 11 insertions(+)
+
+diff --git a/gdb/testsuite/gdb.arch/i386-sse.exp b/gdb/testsuite/gdb.arch/i386-sse.exp
+index fca90256505..4b434abe904 100644
+--- a/gdb/testsuite/gdb.arch/i386-sse.exp
++++ b/gdb/testsuite/gdb.arch/i386-sse.exp
+@@ -75,6 +75,9 @@ if [is_amd64_regs_target] {
+     set nr_regs 8
+ }
+ 
++gdb_test_no_output "set debug arch 1"
++gdb_test_no_output "set debug target 1"
++
+ for { set r 0 } { $r < $nr_regs } { incr r } {
+     gdb_test "print \$xmm$r.v4_float" \
+         ".. = \\{$r, $r.25, $r.5, $r.75\\}.*" \
+@@ -86,6 +89,9 @@ for { set r 0 } { $r < $nr_regs } { incr r } {
+ 
+ for { set r 0 } { $r < $nr_regs } { incr r } {
+     gdb_test "set var \$xmm$r.v4_float\[0\] = $r + 10" "" "set %xmm$r"
++    gdb_test "print \$xmm$r.v4_float" \
++        ".. = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}.*" \
++        "check float contents of %xmm$r after add"
+ }
+ 
+ gdb_test "break [gdb_get_line_number "second breakpoint here"]" \
+@@ -93,6 +99,11 @@ gdb_test "break [gdb_get_line_number "second breakpoint here"]" \
+          "set second breakpoint in main"
+ gdb_continue_to_breakpoint "continue to second breakpoint in main"
+ 
++for { set r 0 } { $r < $nr_regs } { incr r } {
++    gdb_test "print \$xmm$r.v4_float" \
++        ".. = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}.*" \
++        "check float contents of %xmm$r at second breakpoint"
++}
+ for { set r 0 } { $r < $nr_regs } { incr r } {
+     gdb_test "print data\[$r\]" \
+         ".. = \\{f = \\{[expr $r + 10], $r.25, $r.5, $r.75\\}\\}.*" \
diff --git a/gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch b/gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch
index 66fc37c..ec3d24c 100644
--- a/gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch
+++ b/gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch
@@ -53,7 +53,7 @@ index 27718551188..d6fba07b486 100644
  	    }
 +	    if { $interrupted == 0 } {
 +		while { $running_count < $running_expected } {
-+		    sleep 1
++		    sleep 10
 +		    set prev_running_count $running_count
 +		    set running_count 0
 +		    gdb_test_multiple "info threads" "threads running" {
diff --git a/gdb.changes b/gdb.changes
index e014b96..126b4e7 100644
--- a/gdb.changes
+++ b/gdb.changes
@@ -1,3 +1,13 @@
+-------------------------------------------------------------------
+Thu Nov 18 14:01:30 UTC 2021 - Tom de Vries <tdevries@suse.com>
+
+- Maintenance script qa.sh:
+  - Add KFAIL.
+- Patches updated (increase sleep time):
+  * gdb-testsuite-fix-race-in-gdb.threads-detach-step-over.exp.patch
+- Patches added (debug hard to reproduce failure):
+  * gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch
+
 -------------------------------------------------------------------
 Thu Nov 18 11:45:00 UTC 2021 - Tom de Vries <tdevries@suse.com>
 
diff --git a/gdb.spec b/gdb.spec
index f5f8bf5..fbfe53b 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -279,6 +279,8 @@ Patch1101:      gdb-fix-selftest-fails-with-gdb-build-with-O2-flto.patch
 Patch1102:      gdb-testsuite-fix-gdb-server-ext-run-exp-for-obs.patch
 # Tests the zypper install hints.
 Patch1103:      gdb-testsuite-add-gdb.suse-zypper-hint.exp.patch
+# Add debug prints to test-case gdb.arch/i386-sse.exp.
+Patch1104:      gdb-testsuite-debug-gdb.arch-i386-sse.exp.patch
 
 # Patches to upstream
 
@@ -384,6 +386,7 @@ Patch2116:      gdb-testsuite-fix-fail-in-gdb.tui-basic.exp.patch
 Patch2117:      gdb-testsuite-disable-inferior-output-in-gdb.base-foll-vfork.exp.patch
 
 
+
 BuildRequires:  bison
 BuildRequires:  flex
 %if 0%{suse_version} > 1110
@@ -747,6 +750,7 @@ find -name "*.info*"|xargs rm -f
 %patch1101 -p1
 %patch1102 -p1
 %patch1103 -p1
+%patch1104 -p1
 
 %patch1500 -p1
 %patch1501 -p1
diff --git a/qa.sh b/qa.sh
index 6634d24..9423c4e 100644
--- a/qa.sh
+++ b/qa.sh
@@ -121,6 +121,7 @@ kfail=(
     "FAIL: gdb.mi/mi-nonstop.exp: wait for thread exit \(timeout\)"
     # https://sourceware.org/bugzilla/show_bug.cgi?id=26273
     "FAIL: gdb.threads/gcore-stale-thread.exp: save a corefile"
+    "FAIL: gdb.threads/gcore-stale-thread.exp: exited thread is current due to non-stop"
     # https://sourceware.org/bugzilla/show_bug.cgi?id=28467
     # -pie, x86_64 -m32 or i586.
     "FAIL: gdb.base/nodebug.exp: p/c \(int\) array_index\(\"abcdef\",2\)"