f61a679e8e
* Fix 16.0 handling. - Patches added: * gdb-testsuite-fix-gdb.python-py-format-string.exp-wi.patch * gdb-testsuite-fix-gdb.python-py-mi-cmd.exp-with-pyth.patch * gdb-testsuite-fix-gdb.ada-mi_task_arg.exp-on-arm-lin.patch * gdb-testsuite-fix-regexp-in-gdb.ada-mi_var_access.ex.patch * gdb-testsuite-check-gnatmake-version-in-gdb.ada-scal.patch * gdb-testsuite-fix-gdb.arch-arm-pseudo-unwind.exp-wit.patch * gdb-symtab-fix-target-type-of-complex-long-double-on.patch * gdb-testsuite-don-t-use-set-auto-solib-add-off.patch * gdb-tdep-fix-arm-thumb2-hw-breakpoint.patch * gdb-testsuite-fix-gdb.cp-m-static.exp-on-arm.patch * gdb-testsuite-fix-gdb.dwarf2-dw2-fixed-point.exp-on-.patch * gdb-testsuite-fix-gdb.dwarf2-dw2-lines.exp-on-arm-li.patch * gdb-exp-fix-gdb.fortran-intrinsics.exp-fail-on-arm.patch * gdb-tdep-handle-sycall-statx-for-arm-linux.patch * gdb-tdep-fix-recording-of-t1-push.patch * gdb-tdep-handle-syscall-clock_gettime64-for-arm-linu.patch * fix-gdb.dwarf2-shortpiece.exp-on-s390x.patch * handle-address-class-annotation-for-s390x-in-some-te.patch * fix-gdb.dap-step-out.exp-on-s390x.patch * use-setvariable-in-gdb.dap-scopes.exp.patch * fix-gdb.base-finish-pretty.exp-on-s390x.patch * fix-gdb.base-readnever.exp-on-s390x.patch * add-dwarf_expr_piece.op.patch * add-gdbarch_dwarf2_reg_piece_offset-hook.patch * fix-gdb.base-store.exp-on-s390x.patch * fix-gdb.ada-o2_float_param.exp-on-s390x-linux.patch * gdb-testsuite-fix-gdb.base-branch-to-self.exp-on-arm.patch * gdb-tdep-fix-gdb.cp-non-trivial-retval.exp-on-riscv6.patch * gdb-testsuite-fix-gdb.cp-non-trivial-retval.exp-on-a.patch * gdb-testsuite-fix-gdb.rust-completion.exp-timeout-on.patch * gdb-testsuite-require-supports_process_record-in-gdb.patch * gdb-testsuite-fix-regexp-in-gdb.arch-i386-disp-step-.patch * gdb-testsuite-fix-gdb.arch-arm-single-step-kernel-he.patch * gdb-testsuite-fix-gdb.python-py-format-address.exp-o.patch * gdb-testsuite-fix-gdb.arch-riscv-tdesc-regs.exp.patch * gdb-testsuite-fix-gdb.base-list-dot-nodebug-and-make.patch * gdb-testsuite-fix-gdb.base-list-dot-nodebug.exp-on-o.patch * gdb-testsuite-fix-gdb.base-empty-host-env-vars.exp.patch * gdb-prune-inferior-after-switching-inferior.patch * gdb-testsuite-use-nostdlib-in-gdb.base-list-dot-node.patch * gdb-testsuite-fix-timeout-in-gdb.mi-mi-multi-command.patch * gdb-testsuite-require-can_spawn_for_attach-in-gdb.ba.patch * fixup-gdb-6.5-gcore-buffer-limit-test.patch * gdb-testsuite-fix-gdb.ada-big_packed_array.exp-on-s3.patch * gdb-testsuite-fix-gdb.ada-convvar_comp.exp-on-s390x-.patch * gdb-testsuite-fix-regexp-in-gdb.threads-stepi-over-c.patch OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=437
71 lines
1.9 KiB
Diff
71 lines
1.9 KiB
Diff
From 90e16cc4b30a742387b6d8324a862a5e4a91b24e Mon Sep 17 00:00:00 2001
|
|
From: Tom de Vries <tdevries@suse.de>
|
|
Date: Fri, 10 Jan 2025 08:53:29 +0100
|
|
Subject: [PATCH 30/46] [gdb/testsuite] Fix gdb.rust/completion.exp timeout on
|
|
riscv64-linux
|
|
|
|
On riscv64-linux, with test-case gdb.rust/completion.exp I run into the
|
|
following timeout:
|
|
...
|
|
(gdb) complete break pars^M
|
|
FAIL: gdb.rust/completion.exp: complete break pars (timeout)
|
|
...
|
|
|
|
Replaying the scenario outside the testsuite show us that the command takes
|
|
~13 seconds:
|
|
...
|
|
$ gdb -q -batch -x gdb.in
|
|
...
|
|
2025-01-08 12:23:46.853 - command started
|
|
+complete break pars
|
|
break parse.rs
|
|
break parse_printf_format
|
|
break parse_running_mmaps_unix.rs
|
|
break parser.rs
|
|
2025-01-08 12:23:59.600 - command finished
|
|
Command execution time: 12.677752 (cpu), 12.748565 (wall)
|
|
...
|
|
while the timeout is 10 seconds.
|
|
|
|
The riscv64 processor on the server (cfarm91) is not fast (a fair amount of
|
|
the skip_huge_test test-cases times out), but something else is going on as
|
|
well.
|
|
|
|
For x86_64-linux, roughly measuring the size of debug info in the exec get us:
|
|
...
|
|
$ readelf -wi outputs/gdb.rust/completion/completion | wc -l
|
|
2007
|
|
...
|
|
while on the riscv64 server I get:
|
|
...
|
|
$ readelf -wi outputs/gdb.rust/completion/completion | wc -l
|
|
1606950
|
|
...
|
|
|
|
So it seems reasonable that the test is somewhat slower on riscv64.
|
|
|
|
Fix this by using timeout factor 2.
|
|
|
|
Tested on riscv64-linux and x86_64-linux.
|
|
|
|
Approved-By: Tom Tromey <tom@tromey.com>
|
|
---
|
|
gdb/testsuite/gdb.rust/completion.exp | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/gdb/testsuite/gdb.rust/completion.exp b/gdb/testsuite/gdb.rust/completion.exp
|
|
index 02fbdcdf92c..1b0638ad21a 100644
|
|
--- a/gdb/testsuite/gdb.rust/completion.exp
|
|
+++ b/gdb/testsuite/gdb.rust/completion.exp
|
|
@@ -31,4 +31,6 @@ if {![runto ${srcfile}:$line]} {
|
|
return -1
|
|
}
|
|
|
|
-gdb_test "complete break pars" ".*"
|
|
+with_timeout_factor 2 {
|
|
+ gdb_test "complete break pars" ".*"
|
|
+}
|
|
--
|
|
2.43.0
|
|
|