f61a679e8e
* Fix 16.0 handling. - Patches added: * gdb-testsuite-fix-gdb.python-py-format-string.exp-wi.patch * gdb-testsuite-fix-gdb.python-py-mi-cmd.exp-with-pyth.patch * gdb-testsuite-fix-gdb.ada-mi_task_arg.exp-on-arm-lin.patch * gdb-testsuite-fix-regexp-in-gdb.ada-mi_var_access.ex.patch * gdb-testsuite-check-gnatmake-version-in-gdb.ada-scal.patch * gdb-testsuite-fix-gdb.arch-arm-pseudo-unwind.exp-wit.patch * gdb-symtab-fix-target-type-of-complex-long-double-on.patch * gdb-testsuite-don-t-use-set-auto-solib-add-off.patch * gdb-tdep-fix-arm-thumb2-hw-breakpoint.patch * gdb-testsuite-fix-gdb.cp-m-static.exp-on-arm.patch * gdb-testsuite-fix-gdb.dwarf2-dw2-fixed-point.exp-on-.patch * gdb-testsuite-fix-gdb.dwarf2-dw2-lines.exp-on-arm-li.patch * gdb-exp-fix-gdb.fortran-intrinsics.exp-fail-on-arm.patch * gdb-tdep-handle-sycall-statx-for-arm-linux.patch * gdb-tdep-fix-recording-of-t1-push.patch * gdb-tdep-handle-syscall-clock_gettime64-for-arm-linu.patch * fix-gdb.dwarf2-shortpiece.exp-on-s390x.patch * handle-address-class-annotation-for-s390x-in-some-te.patch * fix-gdb.dap-step-out.exp-on-s390x.patch * use-setvariable-in-gdb.dap-scopes.exp.patch * fix-gdb.base-finish-pretty.exp-on-s390x.patch * fix-gdb.base-readnever.exp-on-s390x.patch * add-dwarf_expr_piece.op.patch * add-gdbarch_dwarf2_reg_piece_offset-hook.patch * fix-gdb.base-store.exp-on-s390x.patch * fix-gdb.ada-o2_float_param.exp-on-s390x-linux.patch * gdb-testsuite-fix-gdb.base-branch-to-self.exp-on-arm.patch * gdb-tdep-fix-gdb.cp-non-trivial-retval.exp-on-riscv6.patch * gdb-testsuite-fix-gdb.cp-non-trivial-retval.exp-on-a.patch * gdb-testsuite-fix-gdb.rust-completion.exp-timeout-on.patch * gdb-testsuite-require-supports_process_record-in-gdb.patch * gdb-testsuite-fix-regexp-in-gdb.arch-i386-disp-step-.patch * gdb-testsuite-fix-gdb.arch-arm-single-step-kernel-he.patch * gdb-testsuite-fix-gdb.python-py-format-address.exp-o.patch * gdb-testsuite-fix-gdb.arch-riscv-tdesc-regs.exp.patch * gdb-testsuite-fix-gdb.base-list-dot-nodebug-and-make.patch * gdb-testsuite-fix-gdb.base-list-dot-nodebug.exp-on-o.patch * gdb-testsuite-fix-gdb.base-empty-host-env-vars.exp.patch * gdb-prune-inferior-after-switching-inferior.patch * gdb-testsuite-use-nostdlib-in-gdb.base-list-dot-node.patch * gdb-testsuite-fix-timeout-in-gdb.mi-mi-multi-command.patch * gdb-testsuite-require-can_spawn_for_attach-in-gdb.ba.patch * fixup-gdb-6.5-gcore-buffer-limit-test.patch * gdb-testsuite-fix-gdb.ada-big_packed_array.exp-on-s3.patch * gdb-testsuite-fix-gdb.ada-convvar_comp.exp-on-s390x-.patch * gdb-testsuite-fix-regexp-in-gdb.threads-stepi-over-c.patch OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=437
65 lines
2.3 KiB
Diff
65 lines
2.3 KiB
Diff
From 44651f4eae0a9ecf4a734e996bf75c9cd67e5f63 Mon Sep 17 00:00:00 2001
|
|
From: Tom de Vries <tdevries@suse.de>
|
|
Date: Tue, 10 Dec 2024 20:30:05 +0100
|
|
Subject: [PATCH 20/46] Use setVariable in gdb.dap/scopes.exp
|
|
|
|
The test-case gdb.dap/scopes.exp contains the following outdated comment:
|
|
...
|
|
# setVariable isn't implemented yet, so use the register name.
|
|
...
|
|
|
|
Now that setVariable is implemented, use it to set variable scalar, and remove
|
|
the bit that sets the first register. That part is known to fail on s390x,
|
|
because the first register isn't writeable [1].
|
|
|
|
Tested on x86_64-linux.
|
|
|
|
Suggested-By: Tom Tromey <tom@tromey.com>
|
|
Approved-By: Tom Tromey <tom@tromey.com>
|
|
|
|
[1] https://sourceware.org/pipermail/gdb-patches/2024-December/213823.html
|
|
---
|
|
gdb/testsuite/gdb.dap/scopes.exp | 27 +++++++++------------------
|
|
1 file changed, 9 insertions(+), 18 deletions(-)
|
|
|
|
diff --git a/gdb/testsuite/gdb.dap/scopes.exp b/gdb/testsuite/gdb.dap/scopes.exp
|
|
index aa3bb688c0e..c78ae6e1202 100644
|
|
--- a/gdb/testsuite/gdb.dap/scopes.exp
|
|
+++ b/gdb/testsuite/gdb.dap/scopes.exp
|
|
@@ -133,23 +133,14 @@ set val [dap_check_request_and_response "fetch first register" \
|
|
"variables" \
|
|
[format {o variablesReference [i %d] count [i 1]} $num]]
|
|
|
|
-# Try setting the value to something else.
|
|
-set val [dict get [lindex $val 0] body variables]
|
|
-set name [dict get [lindex $val 0] name]
|
|
-set val [dict get [lindex $val 0] value]
|
|
-# Just make sure it is different from the original value.
|
|
-set val [expr {$val ^ 7}]
|
|
-
|
|
-# setVariable isn't implemented yet, so use the register name. Note
|
|
-# that we sneak the "$" into the name, written in a slightly funny way
|
|
-# to work around apparent TON limitations.
|
|
-set response [dap_check_request_and_response "set first register" \
|
|
- setExpression \
|
|
- [format {o expression [s \$%s] value [s %d] frameId [i %d]} \
|
|
- $name $val $frame_id]]
|
|
-set response [lindex $response 0]
|
|
-
|
|
-gdb_assert {[dict get $response body value] == $val} \
|
|
- "setting register yields updated value"
|
|
+set num [dict get $scope variablesReference]
|
|
+set refs [lindex [dap_check_request_and_response "set variable scalar" \
|
|
+ "setVariable" \
|
|
+ [format {o variablesReference [i %d] name [s scalar] \
|
|
+ value [s 32]} \
|
|
+ $num]] \
|
|
+ 0]
|
|
+gdb_assert { [dict get $refs body value] == 32 } \
|
|
+ "setting variable yields updated value"
|
|
|
|
dap_shutdown
|
|
--
|
|
2.43.0
|
|
|